1 new changeset in galaxy-central: http://bitbucket.org/galaxy/galaxy-central/changeset/eeb9fdfcbe00/ changeset: eeb9fdfcbe00 branches: user: dan date: 2011-06-07 15:04:55 summary: Fix for incorrect variable name reuse ('roles'), occurring when importing multiple datasets from a history into a library. affected #: 1 file (40 bytes) --- a/lib/galaxy/web/controllers/library_common.py Mon Jun 06 16:17:09 2011 -0400 +++ b/lib/galaxy/web/controllers/library_common.py Tue Jun 07 09:04:55 2011 -0400 @@ -1221,7 +1221,7 @@ # it exists, then we need to apply the LIBRARY_MANAGE permission to the library dataset. dataset_manage_permissions_action = trans.app.security_agent.get_action( 'DATASET_MANAGE_PERMISSIONS' ).action flush_needed = False - for action, roles in dataset_permissions_dict.items(): + for action, dataset_permissions_roles in dataset_permissions_dict.items(): if isinstance( action, Action ): action = action.action if action == dataset_manage_permissions_action: @@ -1229,7 +1229,7 @@ action = trans.app.security_agent.get_action( 'LIBRARY_MANAGE' ).action # Allow the permissions inherited from the folder to over-ride the same permissions on the dataset. if action not in current_library_dataset_actions: - for ldp in [ trans.model.LibraryDatasetPermissions( action, ldda.library_dataset, role ) for role in roles ]: + for ldp in [ trans.model.LibraryDatasetPermissions( action, ldda.library_dataset, role ) for role in dataset_permissions_roles ]: trans.sa_session.add( ldp ) flush_needed = True if flush_needed: Repository URL: https://bitbucket.org/galaxy/galaxy-central/ -- This is a commit notification from bitbucket.org. You are receiving this because you have the service enabled, addressing the recipient of this email.