1 new commit in galaxy-central: https://bitbucket.org/galaxy/galaxy-central/commits/81c215f35665/ Changeset: 81c215f35665 User: carlfeberhard Date: 2015-01-30 16:40:21+00:00 Summary: Core, controllers: when parsing ids, stringify to prevent all numeric (but valid) ids from being pre-processed as integers Affected #: 1 file diff -r 1e0f1acf3c54ac7ed12d174f40c2f2f62b01f043 -r 81c215f35665f2361ead5d60fe0a12ee24f31a0b lib/galaxy/web/base/controller.py --- a/lib/galaxy/web/base/controller.py +++ b/lib/galaxy/web/base/controller.py @@ -103,9 +103,11 @@ # ---- parsing query params def decode_id( self, id ): try: - return self.app.security.decode_id( id ) - except: - msg = "Malformed History id ( %s ) specified, unable to decode" % ( str( id ) ) + # note: use str - occasionally a fully numeric id will be placed in post body and parsed as int via JSON + # resulting in error for valid id + return self.app.security.decode_id( str( id ) ) + except ( ValueError, TypeError ): + msg = "Malformed id ( %s ) specified, unable to decode" % ( str( id ) ) raise exceptions.MalformedId( msg, id=str( id ) ) def encode_all_ids( self, trans, rval, recursive=False ): Repository URL: https://bitbucket.org/galaxy/galaxy-central/ -- This is a commit notification from bitbucket.org. You are receiving this because you have the service enabled, addressing the recipient of this email.