1 new commit in galaxy-central: https://bitbucket.org/galaxy/galaxy-central/commits/f2ce61f7d1ad/ Changeset: f2ce61f7d1ad User: jgoecks Date: 2013-12-16 21:35:51 Summary: JavaScript MVC: remove BaseModel because it is not used. Affected #: 3 files diff -r c49caf699d9c5fdec10763ea01b3a167b9ac4bdd -r f2ce61f7d1ad2ea38faedf952aa0abf60ca06e2c static/scripts/mvc/base-mvc.js --- a/static/scripts/mvc/base-mvc.js +++ b/static/scripts/mvc/base-mvc.js @@ -1,26 +1,3 @@ -/** - * Simple base model for any visible element. Includes useful attributes and ability - * to set and track visibility. - */ -var BaseModel = Backbone.Model.extend({ - defaults: { - name: null, - hidden: false - }, - - show: function() { - this.set("hidden", false); - }, - - hide: function() { - this.set("hidden", true); - }, - - is_visible: function() { - return !this.attributes.hidden; - } -}); - /** * Base view that handles visibility based on model's hidden attribute. */ @@ -52,10 +29,10 @@ * * @example * // Add to your models/views at the definition using chaining: - * var MyModel = BaseModel.extend( LoggableMixin ).extend({ // ... }); + * var MyModel = Backbone.Model.extend( LoggableMixin ).extend({ // ... }); * * // or - more explicitly AFTER the definition: - * var MyModel = BaseModel.extend({ + * var MyModel = Backbone.Model.extend({ * logger : console * // ... * this.log( '$#%& it! - broken already...' ); diff -r c49caf699d9c5fdec10763ea01b3a167b9ac4bdd -r f2ce61f7d1ad2ea38faedf952aa0abf60ca06e2c static/scripts/mvc/history/history-model.js --- a/static/scripts/mvc/history/history-model.js +++ b/static/scripts/mvc/history/history-model.js @@ -57,7 +57,6 @@ * @param {Object} historyJSON model data for this History * @param {Object[]} hdaJSON array of model data for this History's HDAs * @param {Object} options any extra settings including logger - * @see BaseModel#initialize */ initialize : function( historyJSON, hdaJSON, options ){ options = options || {}; diff -r c49caf699d9c5fdec10763ea01b3a167b9ac4bdd -r f2ce61f7d1ad2ea38faedf952aa0abf60ca06e2c static/scripts/mvc/user/user-model.js --- a/static/scripts/mvc/user/user-model.js +++ b/static/scripts/mvc/user/user-model.js @@ -67,7 +67,7 @@ if( idOrCurrent === User.CURRENT_ID_STR ){ options.url = this.urlRoot + '/' + User.CURRENT_ID_STR; } - return BaseModel.prototype.fetch.call( this, options ); + return Backbone.Model.prototype.fetch.call( this, options ); }, /** Clears all data from the sessionStorage. Repository URL: https://bitbucket.org/galaxy/galaxy-central/ -- This is a commit notification from bitbucket.org. You are receiving this because you have the service enabled, addressing the recipient of this email.