Branch: refs/heads/dev Home: https://github.com/galaxyproject/galaxy Commit: 7ef9b4cdafd0e2c6e68cba3729d9bd99645ef15f https://github.com/galaxyproject/galaxy/commit/7ef9b4cdafd0e2c6e68cba3729d9b... Author: Max Schaefer <max@semmle.com> Date: 2017-08-16 (Wed, 16 Aug 2017) Changed paths: M client/galaxy/scripts/mvc/job/job-params.js Log Message: ----------- Remove spurious null check. Commit: 43ddd4732034ca2ee658ccd4ab0ae17d4a1bbe40 https://github.com/galaxyproject/galaxy/commit/43ddd4732034ca2ee658ccd4ab0ae... Author: Max Schaefer <max@semmle.com> Date: 2017-08-16 (Wed, 16 Aug 2017) Changed paths: M client/galaxy/scripts/galaxy.pages.js M client/galaxy/scripts/mvc/collection/list-collection-creator.js M client/galaxy/scripts/mvc/dataset/data.js M client/galaxy/scripts/mvc/grid/grid-template.js M client/galaxy/scripts/mvc/grid/grid-view.js M client/galaxy/scripts/mvc/library/library-dataset-view.js M client/galaxy/scripts/mvc/library/library-folder-view.js M client/galaxy/scripts/mvc/library/library-folderlist-view.js M client/galaxy/scripts/mvc/library/library-folderrow-view.js M client/galaxy/scripts/mvc/library/library-foldertoolbar-view.js M client/galaxy/scripts/mvc/library/library-library-view.js M client/galaxy/scripts/mvc/library/library-libraryrow-view.js M client/galaxy/scripts/mvc/library/library-model.js M client/galaxy/scripts/mvc/tool/tool-form-composite.js M client/galaxy/scripts/mvc/toolshed/categories-view.js M client/galaxy/scripts/mvc/toolshed/repo-status-view.js M client/galaxy/scripts/mvc/toolshed/repositories-view.js M client/galaxy/scripts/mvc/toolshed/repository-queue-view.js M client/galaxy/scripts/mvc/toolshed/repository-view.js M client/galaxy/scripts/mvc/toolshed/util.js M client/galaxy/scripts/mvc/toolshed/workflows-view.js M client/galaxy/scripts/mvc/ui/ui-drilldown.js M client/galaxy/scripts/mvc/ui/ui-popover.js M client/galaxy/scripts/mvc/ui/ui-select-default.js M client/galaxy/scripts/mvc/upload/upload-ftp.js M client/galaxy/scripts/mvc/upload/upload-view.js M client/galaxy/scripts/mvc/workflow/workflow-forms.js M client/galaxy/scripts/mvc/workflow/workflow-manager.js M client/galaxy/scripts/mvc/workflow/workflow-terminals.js M client/galaxy/scripts/mvc/workflow/workflow-view.js M client/galaxy/scripts/reports_webapp/run_stats.js M client/galaxy/scripts/ui/scroll-panel.js M client/galaxy/scripts/utils/graph.js M client/galaxy/scripts/utils/uploadbox.js M client/galaxy/scripts/viz/circster.js M client/galaxy/scripts/viz/phyloviz.js M client/galaxy/scripts/viz/trackster/painters.js M client/galaxy/scripts/viz/trackster/tracks.js M client/toolshed/scripts/mvc/groups/group-list-view.js M config/plugins/interactive_environments/rstudio/static/js/crypto/base64.js M config/plugins/interactive_environments/rstudio/static/js/crypto/rstudio.big.js M config/plugins/interactive_environments/rstudio/static/js/crypto/rstudio/base64.js M config/plugins/interactive_environments/rstudio/static/js/crypto/wu/base64.js M config/plugins/visualizations/charts/static/client/components/screenshot.js M config/plugins/visualizations/charts/static/repository/plugins/biojs/drawrnajs/views/optspanel.js M config/plugins/visualizations/charts/static/repository/plugins/biojs/drawrnajs/views/vispanel.js M config/plugins/visualizations/charts/static/repository/visualizations/utilities/tabular-form.js M config/plugins/visualizations/charts/static/repository/visualizations/utilities/tabular-utilities.js M config/plugins/visualizations/graphviz/static/js/toolPanelFunctions.js M config/plugins/webhooks/demo/search/static/script.js M lib/galaxy/web/proxy/js/lib/proxy.js M scripts/communication/template/communication.js Log Message: ----------- Add missing `var` declarations. In all these cases, a variable was not declared to be a local using `var` (and hence was implicitly interpreted as a global variable), but all uses of that variable were preceded by a definition within the same function, suggesting that the variable was, in fact, meant to be local, not global. Commit: 48b835c35cd746c23c185ae69577ab6ae9fc4ee8 https://github.com/galaxyproject/galaxy/commit/48b835c35cd746c23c185ae69577a... Author: Max Schaefer <max@semmle.com> Date: 2017-08-16 (Wed, 16 Aug 2017) Changed paths: M client/galaxy/scripts/viz/circster.js Log Message: ----------- Remove an unused variable. The result of the `_.map` call was never used, so I replaced it with `_.each`. Commit: 8950d4423ff7d02bcf95b417676b2ef1c311333a https://github.com/galaxyproject/galaxy/commit/8950d4423ff7d02bcf95b417676b2... Author: Max Schaefer <max@semmle.com> Date: 2017-08-16 (Wed, 16 Aug 2017) Changed paths: M client/galaxy/scripts/mvc/workflow/workflow-terminals.js Log Message: ----------- Move two variable definitions to combine them with their declarations. Commit: 57c6284269c3256529f9c55953279eccb07dfabf https://github.com/galaxyproject/galaxy/commit/57c6284269c3256529f9c55953279... Author: Max Schaefer <max@semmle.com> Date: 2017-08-16 (Wed, 16 Aug 2017) Changed paths: M static/maps/galaxy.pages.js.map M static/maps/mvc/collection/list-collection-creator.js.map M static/maps/mvc/dataset/data.js.map M static/maps/mvc/grid/grid-template.js.map M static/maps/mvc/grid/grid-view.js.map M static/maps/mvc/library/library-dataset-view.js.map M static/maps/mvc/library/library-folder-view.js.map M static/maps/mvc/library/library-folderlist-view.js.map M static/maps/mvc/library/library-folderrow-view.js.map M static/maps/mvc/library/library-foldertoolbar-view.js.map M static/maps/mvc/library/library-library-view.js.map M static/maps/mvc/library/library-libraryrow-view.js.map M static/maps/mvc/library/library-model.js.map M static/maps/mvc/tool/tool-form-composite.js.map M static/maps/mvc/toolshed/categories-view.js.map M static/maps/mvc/toolshed/repo-status-view.js.map M static/maps/mvc/toolshed/repositories-view.js.map M static/maps/mvc/toolshed/repository-queue-view.js.map M static/maps/mvc/toolshed/repository-view.js.map M static/maps/mvc/toolshed/util.js.map M static/maps/mvc/toolshed/workflows-view.js.map M static/maps/mvc/ui/ui-drilldown.js.map M static/maps/mvc/ui/ui-popover.js.map M static/maps/mvc/ui/ui-select-default.js.map M static/maps/mvc/upload/upload-ftp.js.map M static/maps/mvc/upload/upload-view.js.map M static/maps/mvc/workflow/workflow-forms.js.map M static/maps/mvc/workflow/workflow-manager.js.map M static/maps/mvc/workflow/workflow-terminals.js.map M static/maps/mvc/workflow/workflow-view.js.map M static/maps/reports_webapp/run_stats.js.map M static/maps/ui/scroll-panel.js.map M static/maps/utils/graph.js.map M static/maps/utils/uploadbox.js.map M static/maps/viz/circster.js.map M static/maps/viz/phyloviz.js.map M static/maps/viz/trackster/painters.js.map M static/maps/viz/trackster/tracks.js.map M static/scripts/bundled/admin.bundled.js M static/scripts/bundled/admin.bundled.js.map M static/scripts/bundled/analysis.bundled.js M static/scripts/bundled/analysis.bundled.js.map M static/scripts/bundled/libs.bundled.js.map M static/scripts/galaxy.pages.js M static/scripts/mvc/collection/list-collection-creator.js M static/scripts/mvc/dataset/data.js M static/scripts/mvc/grid/grid-template.js M static/scripts/mvc/grid/grid-view.js M static/scripts/mvc/library/library-dataset-view.js M static/scripts/mvc/library/library-folder-view.js M static/scripts/mvc/library/library-folderlist-view.js M static/scripts/mvc/library/library-folderrow-view.js M static/scripts/mvc/library/library-foldertoolbar-view.js M static/scripts/mvc/library/library-library-view.js M static/scripts/mvc/library/library-libraryrow-view.js M static/scripts/mvc/library/library-model.js M static/scripts/mvc/tool/tool-form-composite.js M static/scripts/mvc/toolshed/categories-view.js M static/scripts/mvc/toolshed/repo-status-view.js M static/scripts/mvc/toolshed/repositories-view.js M static/scripts/mvc/toolshed/repository-queue-view.js M static/scripts/mvc/toolshed/repository-view.js M static/scripts/mvc/toolshed/util.js M static/scripts/mvc/toolshed/workflows-view.js M static/scripts/mvc/ui/ui-drilldown.js M static/scripts/mvc/ui/ui-popover.js M static/scripts/mvc/ui/ui-select-default.js M static/scripts/mvc/upload/upload-ftp.js M static/scripts/mvc/upload/upload-view.js M static/scripts/mvc/workflow/workflow-forms.js M static/scripts/mvc/workflow/workflow-manager.js M static/scripts/mvc/workflow/workflow-terminals.js M static/scripts/mvc/workflow/workflow-view.js M static/scripts/reports_webapp/run_stats.js M static/scripts/ui/scroll-panel.js M static/scripts/utils/graph.js M static/scripts/utils/uploadbox.js M static/scripts/viz/circster.js M static/scripts/viz/phyloviz.js M static/scripts/viz/trackster/painters.js M static/scripts/viz/trackster/tracks.js Log Message: ----------- Run `make client`. Commit: 1b7f25eeaec96ae8b6a5336090dca675076b07bd https://github.com/galaxyproject/galaxy/commit/1b7f25eeaec96ae8b6a5336090dca... Author: Dannon Baker <dannon.baker@gmail.com> Date: 2017-08-16 (Wed, 16 Aug 2017) Changed paths: M client/galaxy/scripts/galaxy.pages.js M client/galaxy/scripts/mvc/collection/list-collection-creator.js M client/galaxy/scripts/mvc/dataset/data.js M client/galaxy/scripts/mvc/grid/grid-template.js M client/galaxy/scripts/mvc/grid/grid-view.js M client/galaxy/scripts/mvc/job/job-params.js M client/galaxy/scripts/mvc/library/library-dataset-view.js M client/galaxy/scripts/mvc/library/library-folder-view.js M client/galaxy/scripts/mvc/library/library-folderlist-view.js M client/galaxy/scripts/mvc/library/library-folderrow-view.js M client/galaxy/scripts/mvc/library/library-foldertoolbar-view.js M client/galaxy/scripts/mvc/library/library-library-view.js M client/galaxy/scripts/mvc/library/library-libraryrow-view.js M client/galaxy/scripts/mvc/library/library-model.js M client/galaxy/scripts/mvc/tool/tool-form-composite.js M client/galaxy/scripts/mvc/toolshed/categories-view.js M client/galaxy/scripts/mvc/toolshed/repo-status-view.js M client/galaxy/scripts/mvc/toolshed/repositories-view.js M client/galaxy/scripts/mvc/toolshed/repository-queue-view.js M client/galaxy/scripts/mvc/toolshed/repository-view.js M client/galaxy/scripts/mvc/toolshed/util.js M client/galaxy/scripts/mvc/toolshed/workflows-view.js M client/galaxy/scripts/mvc/ui/ui-drilldown.js M client/galaxy/scripts/mvc/ui/ui-popover.js M client/galaxy/scripts/mvc/ui/ui-select-default.js M client/galaxy/scripts/mvc/upload/upload-ftp.js M client/galaxy/scripts/mvc/upload/upload-view.js M client/galaxy/scripts/mvc/workflow/workflow-forms.js M client/galaxy/scripts/mvc/workflow/workflow-manager.js M client/galaxy/scripts/mvc/workflow/workflow-terminals.js M client/galaxy/scripts/mvc/workflow/workflow-view.js M client/galaxy/scripts/reports_webapp/run_stats.js M client/galaxy/scripts/ui/scroll-panel.js M client/galaxy/scripts/utils/graph.js M client/galaxy/scripts/utils/uploadbox.js M client/galaxy/scripts/viz/circster.js M client/galaxy/scripts/viz/phyloviz.js M client/galaxy/scripts/viz/trackster/painters.js M client/galaxy/scripts/viz/trackster/tracks.js M client/toolshed/scripts/mvc/groups/group-list-view.js M config/plugins/interactive_environments/rstudio/static/js/crypto/base64.js M config/plugins/interactive_environments/rstudio/static/js/crypto/rstudio.big.js M config/plugins/interactive_environments/rstudio/static/js/crypto/rstudio/base64.js M config/plugins/interactive_environments/rstudio/static/js/crypto/wu/base64.js M config/plugins/visualizations/charts/static/client/components/screenshot.js M config/plugins/visualizations/charts/static/repository/plugins/biojs/drawrnajs/views/optspanel.js M config/plugins/visualizations/charts/static/repository/plugins/biojs/drawrnajs/views/vispanel.js M config/plugins/visualizations/charts/static/repository/visualizations/utilities/tabular-form.js M config/plugins/visualizations/charts/static/repository/visualizations/utilities/tabular-utilities.js M config/plugins/visualizations/graphviz/static/js/toolPanelFunctions.js M config/plugins/webhooks/demo/search/static/script.js M lib/galaxy/web/proxy/js/lib/proxy.js M scripts/communication/template/communication.js M static/maps/galaxy.pages.js.map M static/maps/mvc/collection/list-collection-creator.js.map M static/maps/mvc/dataset/data.js.map M static/maps/mvc/grid/grid-template.js.map M static/maps/mvc/grid/grid-view.js.map M static/maps/mvc/library/library-dataset-view.js.map M static/maps/mvc/library/library-folder-view.js.map M static/maps/mvc/library/library-folderlist-view.js.map M static/maps/mvc/library/library-folderrow-view.js.map M static/maps/mvc/library/library-foldertoolbar-view.js.map M static/maps/mvc/library/library-library-view.js.map M static/maps/mvc/library/library-libraryrow-view.js.map M static/maps/mvc/library/library-model.js.map M static/maps/mvc/tool/tool-form-composite.js.map M static/maps/mvc/toolshed/categories-view.js.map M static/maps/mvc/toolshed/repo-status-view.js.map M static/maps/mvc/toolshed/repositories-view.js.map M static/maps/mvc/toolshed/repository-queue-view.js.map M static/maps/mvc/toolshed/repository-view.js.map M static/maps/mvc/toolshed/util.js.map M static/maps/mvc/toolshed/workflows-view.js.map M static/maps/mvc/ui/ui-drilldown.js.map M static/maps/mvc/ui/ui-popover.js.map M static/maps/mvc/ui/ui-select-default.js.map M static/maps/mvc/upload/upload-ftp.js.map M static/maps/mvc/upload/upload-view.js.map M static/maps/mvc/workflow/workflow-forms.js.map M static/maps/mvc/workflow/workflow-manager.js.map M static/maps/mvc/workflow/workflow-terminals.js.map M static/maps/mvc/workflow/workflow-view.js.map M static/maps/reports_webapp/run_stats.js.map M static/maps/ui/scroll-panel.js.map M static/maps/utils/graph.js.map M static/maps/utils/uploadbox.js.map M static/maps/viz/circster.js.map M static/maps/viz/phyloviz.js.map M static/maps/viz/trackster/painters.js.map M static/maps/viz/trackster/tracks.js.map M static/scripts/bundled/admin.bundled.js M static/scripts/bundled/admin.bundled.js.map M static/scripts/bundled/analysis.bundled.js M static/scripts/bundled/analysis.bundled.js.map M static/scripts/bundled/libs.bundled.js.map M static/scripts/galaxy.pages.js M static/scripts/mvc/collection/list-collection-creator.js M static/scripts/mvc/dataset/data.js M static/scripts/mvc/grid/grid-template.js M static/scripts/mvc/grid/grid-view.js M static/scripts/mvc/library/library-dataset-view.js M static/scripts/mvc/library/library-folder-view.js M static/scripts/mvc/library/library-folderlist-view.js M static/scripts/mvc/library/library-folderrow-view.js M static/scripts/mvc/library/library-foldertoolbar-view.js M static/scripts/mvc/library/library-library-view.js M static/scripts/mvc/library/library-libraryrow-view.js M static/scripts/mvc/library/library-model.js M static/scripts/mvc/tool/tool-form-composite.js M static/scripts/mvc/toolshed/categories-view.js M static/scripts/mvc/toolshed/repo-status-view.js M static/scripts/mvc/toolshed/repositories-view.js M static/scripts/mvc/toolshed/repository-queue-view.js M static/scripts/mvc/toolshed/repository-view.js M static/scripts/mvc/toolshed/util.js M static/scripts/mvc/toolshed/workflows-view.js M static/scripts/mvc/ui/ui-drilldown.js M static/scripts/mvc/ui/ui-popover.js M static/scripts/mvc/ui/ui-select-default.js M static/scripts/mvc/upload/upload-ftp.js M static/scripts/mvc/upload/upload-view.js M static/scripts/mvc/workflow/workflow-forms.js M static/scripts/mvc/workflow/workflow-manager.js M static/scripts/mvc/workflow/workflow-terminals.js M static/scripts/mvc/workflow/workflow-view.js M static/scripts/reports_webapp/run_stats.js M static/scripts/ui/scroll-panel.js M static/scripts/utils/graph.js M static/scripts/utils/uploadbox.js M static/scripts/viz/circster.js M static/scripts/viz/phyloviz.js M static/scripts/viz/trackster/painters.js M static/scripts/viz/trackster/tracks.js Log Message: ----------- Merge pull request #4421 from xiemaisi/fix-lgtm-alerts Fix lgtm alerts Compare: https://github.com/galaxyproject/galaxy/compare/c5a91491c646...1b7f25eeaec9