Branch: refs/heads/release_18.01 Home: https://github.com/galaxyproject/galaxy Commit: d60b80a537ae4b9d580805014c99d74bb6598896 https://github.com/galaxyproject/galaxy/commit/d60b80a537ae4b9d580805014c99d... Author: mvdbeek <m.vandenbeek@gmail.com> Date: 2018-03-08 (Thu, 08 Mar 2018) Changed paths: M lib/galaxy/webapps/galaxy/controllers/history.py Log Message: ----------- Show error message if user tries purging datasets without having an associated history. This can be seen by pasting http://<gx_instance>/history/purge_deleted_datasets into an anonymous browser session (be careful to not delete something important ;)). Traceback is: ``` AttributeError: 'NoneType' object has no attribute 'datasets' File "galaxy/web/framework/middleware/sentry.py", line 43, in __call__ iterable = self.application(environ, start_response) File "/cvmfs/main.galaxyproject.org/venv/lib/python2.7/site-packages/paste/recursive.py", line 85, in __call__ return self.application(environ, start_response) File "galaxy/web/framework/middleware/statsd.py", line 35, in __call__ req = self.application(environ, start_response) File "/cvmfs/main.galaxyproject.org/venv/lib/python2.7/site-packages/paste/httpexceptions.py", line 640, in __call__ return self.application(environ, start_response) File "galaxy/web/framework/base.py", line 136, in __call__ return self.handle_request(environ, start_response) File "galaxy/web/framework/base.py", line 215, in handle_request body = method(trans, **kwargs) File "galaxy/webapps/galaxy/controllers/history.py", line 1108, in purge_deleted_datasets for hda in trans.history.datasets: ``` Commit: 1761d85e7299ddd34565794c43b0c761b44a0bc5 https://github.com/galaxyproject/galaxy/commit/1761d85e7299ddd34565794c43b0c... Author: Martin Cech <marten@bx.psu.edu> Date: 2018-03-08 (Thu, 08 Mar 2018) Changed paths: M lib/galaxy/webapps/galaxy/controllers/history.py Log Message: ----------- Merge pull request #5664 from mvdbeek/show_error_message_if_no_history_associated [18.01] Show error message if user tries purging datasets Compare: https://github.com/galaxyproject/galaxy/compare/a0fd6307562b...1761d85e7299