1 new commit in galaxy-central: https://bitbucket.org/galaxy/galaxy-central/commits/e5d2170d26ab/ Changeset: e5d2170d26ab User: nsoranzo Date: 2013-11-19 19:36:17 Summary: Fix API workflow show for workflows created with history Extract Workflow. To reproduce: 1) for an existing history, select "Extract Workflow" from the history menu 2) find the id of the new workflow, e.g. by opening /api/workflows/ 3) open /api/workflows/$workflow_id Result is an Internal Server Error. In Galaxy log: galaxy.web.framework ERROR 2013-11-19 12:44:17,367 Uncaught exception in exposed API method: Traceback (most recent call last): File "/srv/galaxy/lib/galaxy/web/framework/__init__.py", line 197, in decorator rval = func( self, trans, *args, **kwargs) File "/srv/galaxy/lib/galaxy/webapps/galaxy/api/workflows.py", line 77, in show inputs[step.id] = {'label':step.tool_inputs['name'], 'value':""} TypeError: 'NoneType' object has no attribute '__getitem__' Reported-by: Simone Leo <simone.leo@crs4.it> Affected #: 2 files diff -r f2186f4796ad4c6aa2c9191f9804d8f5d59eb15d -r e5d2170d26ab226d326b80003e8838b2d255d6c4 lib/galaxy/webapps/galaxy/api/workflows.py --- a/lib/galaxy/webapps/galaxy/api/workflows.py +++ b/lib/galaxy/webapps/galaxy/api/workflows.py @@ -73,7 +73,10 @@ inputs = {} for step in latest_workflow.steps: if step.type == 'data_input': - inputs[step.id] = {'label':step.tool_inputs['name'], 'value':""} + if step.tool_inputs and "name" in step.tool_inputs: + inputs[step.id] = {'label':step.tool_inputs['name'], 'value':""} + else: + inputs[step.id] = {'label':"Input Dataset", 'value':""} else: pass # Eventually, allow regular tool parameters to be inserted and modified at runtime. diff -r f2186f4796ad4c6aa2c9191f9804d8f5d59eb15d -r e5d2170d26ab226d326b80003e8838b2d255d6c4 lib/galaxy/webapps/galaxy/controllers/workflow.py --- a/lib/galaxy/webapps/galaxy/controllers/workflow.py +++ b/lib/galaxy/webapps/galaxy/controllers/workflow.py @@ -1223,6 +1223,7 @@ for hid in dataset_ids: step = model.WorkflowStep() step.type = 'data_input' + step.tool_inputs = dict( name="Input Dataset" ) hid_to_output_pair[ hid ] = ( step, 'output' ) steps.append( step ) # Tool steps Repository URL: https://bitbucket.org/galaxy/galaxy-central/ -- This is a commit notification from bitbucket.org. You are receiving this because you have the service enabled, addressing the recipient of this email.