Branch: refs/heads/dev Home: https://github.com/galaxyproject/galaxy Commit: 01eb5f04e6661d389d8c8f681373b5c50fe259b9 https://github.com/galaxyproject/galaxy/commit/01eb5f04e6661d389d8c8f681373b... Author: John Chilton <jmchilton@gmail.com> Date: 2017-09-20 (Wed, 20 Sep 2017) Changed paths: M test/galaxy_selenium/navigates_galaxy.py M test/selenium_tests/framework.py M test/selenium_tests/test_custom_builds.py M test/selenium_tests/test_history_sharing.py M test/selenium_tests/test_saved_histories.py Log Message: ----------- Aggressively retry buggy submit_login() function in Selenium tests. I don't get why when we click submit the user does not actually get logged in, but based on the last round of improved error messages this seems to be the case. You might think there is some callback in the login form that doesn't get registered by the time Selenium clicks the submit button - but this doesn't seem to be the case - I don't see any jquery magic happening in login.mako. Should fix failures like this: https://jenkins.galaxyproject.org/job/selenium/482/testReport/junit/selenium... I'd say at this point this is the most common problem in the Selenium tests. This also introduces a framework for taking state snapshots of the Galaxy interface during tests that will only get written out if the tests fail. We now take screenshots before and after submitting the login form but this is a general purpose debugging mechanism that could be used other places. Commit: 35cd9339453dd245ab4c317517ea1dfafb6af147 https://github.com/galaxyproject/galaxy/commit/35cd9339453dd245ab4c317517ea1... Author: Martin Cech <marten@bx.psu.edu> Date: 2017-09-21 (Thu, 21 Sep 2017) Changed paths: M test/galaxy_selenium/navigates_galaxy.py M test/selenium_tests/framework.py M test/selenium_tests/test_custom_builds.py M test/selenium_tests/test_history_sharing.py M test/selenium_tests/test_saved_histories.py Log Message: ----------- Merge pull request #4655 from jmchilton/selenium_fixes_29 Aggressively retry buggy submit_login() function in Selenium tests. Compare: https://github.com/galaxyproject/galaxy/compare/24557fdeaab2...35cd9339453d