commit/galaxy-central: 2 new changesets
2 new commits in galaxy-central: https://bitbucket.org/galaxy/galaxy-central/commits/0f854a6a519c/ Changeset: 0f854a6a519c User: jmchilton Date: 2014-04-25 20:00:09 Summary: Disable select2 for all multi-select inputs. These have been nothing but trouble (they have been disabled some places) and are awkward in those places that have not been changed. Is there any place in Galaxy where multi-select inputs + select2 are being used to create a desirable UX? If yes, can we just create a class for these particular widgets and target it with a boolean expression on the same line? Affected #: 1 file diff -r 666a75d94ee91091d94b65ffbfe700224ad58f15 -r 0f854a6a519ce3a86e04701f01de42af93ed3d5d static/scripts/galaxy.base.js --- a/static/scripts/galaxy.base.js +++ b/static/scripts/galaxy.base.js @@ -261,7 +261,7 @@ select_elts = select_elts || $('select'); select_elts.each( function() { - var select_elt = $(this); + var select_elt = $(this).not('[multiple]'); // Make sure that options is within range. var num_options = select_elt.find('option').length; if ( (num_options < min_length) || (num_options > max_length) ) { https://bitbucket.org/galaxy/galaxy-central/commits/c78a4a3d51cd/ Changeset: c78a4a3d51cd User: jmchilton Date: 2014-05-06 17:08:39 Summary: Merged in jmchilton/galaxy-central-fork-1 (pull request #379) Disable select2 for all multi-select inputs. Affected #: 1 file diff -r 09f80fcdfd85bf1b009b9c831e51fa92a6ff9306 -r c78a4a3d51cdcd99754822d479798ed324ed9655 static/scripts/galaxy.base.js --- a/static/scripts/galaxy.base.js +++ b/static/scripts/galaxy.base.js @@ -261,7 +261,7 @@ select_elts = select_elts || $('select'); select_elts.each( function() { - var select_elt = $(this); + var select_elt = $(this).not('[multiple]'); // Make sure that options is within range. var num_options = select_elt.find('option').length; if ( (num_options < min_length) || (num_options > max_length) ) { Repository URL: https://bitbucket.org/galaxy/galaxy-central/ -- This is a commit notification from bitbucket.org. You are receiving this because you have the service enabled, addressing the recipient of this email.
participants (1)
-
commits-noreply@bitbucket.org