[galaxyproject/galaxy] 283ab0: Improve performance bugs and misleading summary in...
Branch: refs/heads/release_18.01 Home: https://github.com/galaxyproject/galaxy Commit: 283ab0459fe25cc26606ccae86bdd99e1c6765b9 https://github.com/galaxyproject/galaxy/commit/283ab0459fe25cc26606ccae86bdd... Author: John Chilton <jmchilton@gmail.com> Date: 2018-02-14 (Wed, 14 Feb 2018) Changed paths: M client/galaxy/scripts/mvc/history/history-list.js M client/galaxy/style/less/base.less M lib/galaxy/model/mapping.py M lib/galaxy/web/framework/helpers/grids.py M lib/galaxy/webapps/galaxy/controllers/history.py M test/selenium_tests/test_saved_histories.py Log Message: ----------- Improve performance bugs and misleading summary info in history list. Prefetch shared user information as counts instead of objects and do so in initial query to eliminate an extra 15 SQL queries per page and load less data related to sharing. Replace columns that would cause HDA information to be joined into the query (history size and HDA state counts) with a spinner that will be fetched in subsequent queries on the client end. There can hundreds of thousands of datasets per history - this information shouldn't be summarized to get the initial page to render - it can be fetched one history at a time once the page is rendered. This commit also adds a new column "Items" that corresponds to the next HID - and that I think is a good summary of the "history size" before the dataset state information is loaded and even gives additional information because that count includes collections. This also renders state information for deleted and hidden datasets that was previously missing and could cause confusion. That said I don't like the dataset summaries - I'd rather just have the item count and then job state summaries. Commit: 755fb9fb21581f29ba96a1465ca73e72eb68b610 https://github.com/galaxyproject/galaxy/commit/755fb9fb21581f29ba96a1465ca73... Author: Martin Cech <marten@bx.psu.edu> Date: 2018-02-15 (Thu, 15 Feb 2018) Changed paths: M client/galaxy/scripts/mvc/history/history-list.js M client/galaxy/style/less/base.less M client/galaxy/style/less/galaxy_variables.less Log Message: ----------- style changes for history lists * include title for all state indicators * shorten title * change style of deleted indicator * comment out unused less variables Commit: 42c12c51884454c60a8b109f1ae7e814eeeaf7a4 https://github.com/galaxyproject/galaxy/commit/42c12c51884454c60a8b109f1ae7e... Author: Martin Cech <marten@bx.psu.edu> Date: 2018-02-15 (Thu, 15 Feb 2018) Changed paths: M client/galaxy/scripts/mvc/history/history-list.js M client/galaxy/style/less/base.less M client/galaxy/style/less/galaxy_variables.less M lib/galaxy/model/mapping.py M lib/galaxy/web/framework/helpers/grids.py M lib/galaxy/webapps/galaxy/controllers/history.py M test/selenium_tests/test_saved_histories.py Log Message: ----------- Merge pull request #5533 from jmchilton/history_list_opts [18.01] Improve performance bugs and misleading summary info in history list. Compare: https://github.com/galaxyproject/galaxy/compare/1ccd55a500e5...42c12c518844
participants (1)
-
GitHub