1 new commit in galaxy-central: https://bitbucket.org/galaxy/galaxy-central/commits/dde0e4592530/ changeset: dde0e4592530 user: dannon date: 2013-03-05 22:07:35 summary: Strip dead test code (that actually threw an exception when enabled due to undefined variables). affected #: 1 file diff -r a7814c5352318f5e81d77315bc9fff413673d483 -r dde0e4592530c3be40e4464b4347817b25a6aa62 lib/galaxy/security/__init__.py --- a/lib/galaxy/security/__init__.py +++ b/lib/galaxy/security/__init__.py @@ -903,26 +903,10 @@ .filter( and_( trans.app.model.DatasetPermissions.dataset_id.in_( dataset_ids ), trans.app.model.DatasetPermissions.action == self.permitted_actions.DATASET_ACCESS.action ) ) \ .all() - # Every dataset returned has "access" privileges associated with it, # so it's not public. for permission in access_data_perms: datasets_public[ permission.dataset_id ] = False - - # Test code: Check if the results match up with the original: - test_code = False - if test_code: - log.debug( "datasets_are_public test: check datasets_are_public matches dataset_is_public:" ) - test_success = True - for dataset in datasets: - orig_is_public = self.dataset_is_public( dataset ) - if orig_is_public == datasets_public[ dataset.id ]: - log.debug( "\tMatch for dataset %d" % dataset.id ) - else: - success = False - log.error( "\tERROR: Did not match: single is_public: %s; multiple is_public: %s" - % ( single_is_public, datasets_public[ dataset.id ] ) ) - log.debug( "datasets_are_public: test succeeded? %s" % test_success ) return datasets_public Repository URL: https://bitbucket.org/galaxy/galaxy-central/ -- This is a commit notification from bitbucket.org. You are receiving this because you have the service enabled, addressing the recipient of this email.