[galaxyproject/galaxy] 368363: Revert "Refactor code for clarity"
Branch: refs/heads/dev Home: https://github.com/galaxyproject/galaxy Commit: 3683639be9b0b8402a33404a4c92bb3e77946052 https://github.com/galaxyproject/galaxy/commit/3683639be9b0b8402a33404a4c92b... Author: mvdbeek <m.vandenbeek@gmail.com> Date: 2018-05-25 (Fri, 25 May 2018) Changed paths: M lib/galaxy/tools/parameters/basic.py Log Message: ----------- Revert "Refactor code for clarity" This reverts commit 91e97b60968d6813bd7a28d0d60e778b288ac385. The commit to revert causes https://github.com/galaxyproject/galaxy/issues/6219, where the `optional="True"` flag is not repected anymore. This is because we raise an exception before checking that `value` may be legitimately `None`. Commit: 9df63093664cda98890f2cfafe716f63a735d39f https://github.com/galaxyproject/galaxy/commit/9df63093664cda98890f2cfafe716... Author: mvdbeek <m.vandenbeek@gmail.com> Date: 2018-05-25 (Fri, 25 May 2018) Changed paths: M lib/galaxy/tools/parameters/basic.py Log Message: ----------- Fix optional input in DrillDownSelectToolParameter.from_json() as well Thanks for catching that @nsoranzo Commit: 2d0c1478f9bbb77b4d1d4c9b7291975ab0905395 https://github.com/galaxyproject/galaxy/commit/2d0c1478f9bbb77b4d1d4c9b72919... Author: ValentinChCloud <chavaldranis@gmail.com> Date: 2018-05-25 (Fri, 25 May 2018) Changed paths: M lib/galaxy/webapps/galaxy/api/tools.py Log Message: ----------- Correct api/tools/{tool_id}/build Commit: 8b37b5ad871b56a31fb4cbbed55b84fb3347bfb8 https://github.com/galaxyproject/galaxy/commit/8b37b5ad871b56a31fb4cbbed55b8... Author: Martin Cech <marten@bx.psu.edu> Date: 2018-05-25 (Fri, 25 May 2018) Changed paths: M lib/galaxy/webapps/galaxy/api/tools.py Log Message: ----------- Merge pull request #6228 from ValentinChCloud/api_doc [18.05] Add io_details and link_details in api tools doc Commit: ec45c970c57af9d2237f6d5e3e6c30f0cbbfce20 https://github.com/galaxyproject/galaxy/commit/ec45c970c57af9d2237f6d5e3e6c3... Author: Nicola Soranzo <nicola.soranzo@earlham.ac.uk> Date: 2018-05-25 (Fri, 25 May 2018) Changed paths: A test/functional/tools/empty_select.xml Log Message: ----------- Add test tool for empty optional select To easily reproduce https://github.com/galaxyproject/galaxy/issues/6219 . Commit: e91f91b5f217c90e937b2608b91a9672300960c7 https://github.com/galaxyproject/galaxy/commit/e91f91b5f217c90e937b2608b91a9... Author: Dannon <dannon.baker@gmail.com> Date: 2018-05-25 (Fri, 25 May 2018) Changed paths: M lib/galaxy/tools/parameters/basic.py A test/functional/tools/empty_select.xml Log Message: ----------- Merge pull request #6222 from mvdbeek/fix_optional_input [18.05] Fix optional="True" inputs Commit: 13b5883dd6054304a166a3a8fdfd63ae27ec2eaa https://github.com/galaxyproject/galaxy/commit/13b5883dd6054304a166a3a8fdfd6... Author: Dannon Baker <dannon.baker@gmail.com> Date: 2018-05-25 (Fri, 25 May 2018) Changed paths: M lib/galaxy/tools/parameters/basic.py M lib/galaxy/webapps/galaxy/api/tools.py A test/functional/tools/empty_select.xml Log Message: ----------- Merge remote-tracking branch 'upstream/release_18.05' into dev Compare: https://github.com/galaxyproject/galaxy/compare/08372c90d6ef...13b5883dd605 **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.
participants (1)
-
GitHub