commit/galaxy-central: greg: Fix bug introduced in 5695: 8731db1b2bfb - hda.history must have a user before the check for hda.dataset.has_manage_permissions_roles.
1 new changeset in galaxy-central: http://bitbucket.org/galaxy/galaxy-central/changeset/036eace358b7/ changeset: 036eace358b7 user: greg date: 2011-06-14 15:52:05 summary: Fix bug introduced in 5695: 8731db1b2bfb - hda.history must have a user before the check for hda.dataset.has_manage_permissions_roles. affected #: 1 file (22 bytes) --- a/lib/galaxy/web/controllers/root.py Mon Jun 13 16:07:04 2011 -0400 +++ b/lib/galaxy/web/controllers/root.py Tue Jun 14 09:52:05 2011 -0400 @@ -316,7 +316,7 @@ if id is not None and data.history.user is not None and data.history.user != trans.user: return trans.show_error_message( "This instance of a dataset (%s) in a history does not belong to you." % ( data.id ) ) current_user_roles = trans.get_current_user_roles() - if not data.dataset.has_manage_permissions_roles( trans ): + if data.history.user and not data.dataset.has_manage_permissions_roles( trans ): # Permission setting related to DATASET_MANAGE_PERMISSIONS was broken for a period of time, # so it is possible that some Datasets have no roles associated with the DATASET_MANAGE_PERMISSIONS # permission. In this case, we'll reset this permission to the hda user's private role. Repository URL: https://bitbucket.org/galaxy/galaxy-central/ -- This is a commit notification from bitbucket.org. You are receiving this because you have the service enabled, addressing the recipient of this email.
participants (1)
-
Bitbucket