Branch: refs/heads/dev Home: https://github.com/galaxyproject/galaxy Commit: a9ed02de64637748c43fd7744a47d09b80d01327 https://github.com/galaxyproject/galaxy/commit/a9ed02de64637748c43fd7744a47d... Author: Dannon Baker <dannon.baker@gmail.com> Date: 2019-01-15 (Tue, 15 Jan 2019) Changed paths: A client/.eslintrc.js M client/package.json M client/yarn.lock Log Message: ----------- Add eslint, start setting up targets. Needs exclusions, rule tweaking, and a ton of quick error resolution. Commit: 5811e7268256fc3364ad2e08388f82c42132ecc7 https://github.com/galaxyproject/galaxy/commit/5811e7268256fc3364ad2e08388f8... Author: Dannon Baker <dannon.baker@gmail.com> Date: 2019-01-15 (Tue, 15 Jan 2019) Changed paths: M client/galaxy/scripts/galaxy.interactive_environments.js M client/galaxy/scripts/mvc/tool/tool-form-composite.js M client/galaxy/style/scss/base.scss Log Message: ----------- Sync formatting. Commit: e5691776396a7b7d8a993e23ebf670960dc6284e https://github.com/galaxyproject/galaxy/commit/e5691776396a7b7d8a993e23ebf67... Author: Dannon Baker <dannon.baker@gmail.com> Date: 2019-01-15 (Tue, 15 Jan 2019) Changed paths: M client/package.json A client/prettier.config.js M client/yarn.lock Log Message: ----------- Upgrade prettier, simplify config/exclusion, haven't run it yet. Commit: 49eecece5b8398ec6552e32d1448bb1a51370223 https://github.com/galaxyproject/galaxy/commit/49eecece5b8398ec6552e32d1448b... Author: Dannon Baker <dannon.baker@gmail.com> Date: 2019-01-15 (Tue, 15 Jan 2019) Changed paths: M client/galaxy/scripts/mvc/visualization/chart/components/screenshot.js Log Message: ----------- Avoid empty catch/log error. Commit: 89d3fc3c54ddf3bf09896b8d20c3d43dc0d70df1 https://github.com/galaxyproject/galaxy/commit/89d3fc3c54ddf3bf09896b8d20c3d... Author: Dannon Baker <dannon.baker@gmail.com> Date: 2019-01-15 (Tue, 15 Jan 2019) Changed paths: M client/galaxy/scripts/mvc/annotation.js M client/galaxy/scripts/mvc/base-mvc.js M client/galaxy/scripts/mvc/collection/base-creator.js M client/galaxy/scripts/mvc/collection/collection-li-edit.js M client/galaxy/scripts/mvc/collection/collection-model.js M client/galaxy/scripts/mvc/collection/collection-view-edit.js M client/galaxy/scripts/mvc/collection/list-collection-creator.js M client/galaxy/scripts/mvc/collection/list-of-pairs-collection-creator.js M client/galaxy/scripts/mvc/collection/pair-collection-creator.js M client/galaxy/scripts/mvc/dataset/dataset-choice.js M client/galaxy/scripts/mvc/form/form-input.js M client/galaxy/scripts/mvc/form/form-parameters.js M client/galaxy/scripts/mvc/form/form-section.js M client/galaxy/scripts/mvc/form/form-view.js M client/galaxy/scripts/mvc/grid/grid-model.js M client/galaxy/scripts/mvc/history/hda-li-edit.js M client/galaxy/scripts/mvc/history/hda-li.js M client/galaxy/scripts/mvc/history/hda-model.js M client/galaxy/scripts/mvc/history/hdca-model.js M client/galaxy/scripts/mvc/history/history-item-li.js M client/galaxy/scripts/mvc/history/history-preferences.js M client/galaxy/scripts/mvc/history/history-view-annotated.js M client/galaxy/scripts/mvc/history/job-dag.js M client/galaxy/scripts/mvc/history/options-menu.js M client/galaxy/scripts/mvc/job/job-li.js M client/galaxy/scripts/mvc/lazy/lazy-limited.js M client/galaxy/scripts/mvc/library/library-librarylist-view.js M client/galaxy/scripts/mvc/rules/rule-definitions.js M client/galaxy/scripts/mvc/ui/icon-button.js M client/galaxy/scripts/mvc/ui/popup-menu.js M client/galaxy/scripts/mvc/ui/ui-buttons.js M client/galaxy/scripts/mvc/ui/ui-color-picker.js M client/galaxy/scripts/mvc/ui/ui-drilldown.js M client/galaxy/scripts/mvc/ui/ui-list.js M client/galaxy/scripts/mvc/ui/ui-misc.js M client/galaxy/scripts/mvc/ui/ui-modal.js M client/galaxy/scripts/mvc/ui/ui-portlet.js M client/galaxy/scripts/mvc/ui/ui-select-default.js M client/galaxy/scripts/mvc/ui/ui-select-genomespace.js M client/galaxy/scripts/mvc/ui/ui-slider.js M client/galaxy/scripts/mvc/ui/ui-table.js M client/galaxy/scripts/mvc/upload/collection/collection-row.js M client/galaxy/scripts/mvc/upload/composite/composite-row.js M client/galaxy/scripts/mvc/upload/default/default-row.js M client/galaxy/scripts/mvc/upload/upload-button.js M client/galaxy/scripts/mvc/upload/upload-extension.js M client/galaxy/scripts/mvc/upload/upload-model.js M client/galaxy/scripts/mvc/upload/upload-settings.js M client/galaxy/scripts/mvc/visualization/chart/components/screenshot.js M client/galaxy/scripts/mvc/visualization/chart/views/editor.js M client/galaxy/scripts/mvc/visualization/chart/views/menu.js M client/galaxy/scripts/mvc/visualization/chart/views/settings.js M client/galaxy/scripts/mvc/visualization/chart/views/viewer.js M client/galaxy/scripts/mvc/workflow/workflow-connector.js M client/galaxy/scripts/mvc/workflow/workflow-terminals.js M client/galaxy/scripts/mvc/workflow/workflow-view-node.js M client/galaxy/scripts/mvc/workflow/workflow-view-terminals.js Log Message: ----------- Fix most import errors in scripts/mvc Commit: 86dd5f63b448d4e8a514ceca92d5745bf6350ad8 https://github.com/galaxyproject/galaxy/commit/86dd5f63b448d4e8a514ceca92d57... Author: Dannon Baker <dannon.baker@gmail.com> Date: 2019-01-15 (Tue, 15 Jan 2019) Changed paths: M client/galaxy/scripts/mvc/dataset/data.js Log Message: ----------- Relocate search function; should be refactored... Commit: b8e56700dbe55fe13b865122a9ac83d107306483 https://github.com/galaxyproject/galaxy/commit/b8e56700dbe55fe13b865122a9ac8... Author: Dannon Baker <dannon.baker@gmail.com> Date: 2019-01-15 (Tue, 15 Jan 2019) Changed paths: M client/galaxy/scripts/mvc/grid/grid-view.js M client/galaxy/scripts/mvc/ui/ui-select.js Log Message: ----------- Fix no-useless-escape errors. Commit: 9cc5a01b94caf4644442fb8081da6da408850a19 https://github.com/galaxyproject/galaxy/commit/9cc5a01b94caf4644442fb8081da6... Author: Dannon Baker <dannon.baker@gmail.com> Date: 2019-01-15 (Tue, 15 Jan 2019) Changed paths: M client/galaxy/scripts/mvc/history/job-dag.js Log Message: ----------- Fix Graph reference in job-dag. Commit: 9174cb4b1df890a29d8341ad2705184b9becbb5d https://github.com/galaxyproject/galaxy/commit/9174cb4b1df890a29d8341ad27051... Author: Dannon Baker <dannon.baker@gmail.com> Date: 2019-01-15 (Tue, 15 Jan 2019) Changed paths: M client/galaxy/scripts/mvc/tool/tool-genomespace.js Log Message: ----------- Fix genomespace tool reference to config/errorcallback Commit: 02ccffb6801924b6f1d4dc6302e686bde28ef1ac https://github.com/galaxyproject/galaxy/commit/02ccffb6801924b6f1d4dc6302e68... Author: Dannon Baker <dannon.baker@gmail.com> Date: 2019-01-15 (Tue, 15 Jan 2019) Changed paths: M client/galaxy/scripts/mvc/history/options-menu.js Log Message: ----------- Fix reference to galaxy_main frame Commit: 8c94cdf91518a21b79793b73473fe3937b4016e8 https://github.com/galaxyproject/galaxy/commit/8c94cdf91518a21b79793b73473fe... Author: Dannon Baker <dannon.baker@gmail.com> Date: 2019-01-15 (Tue, 15 Jan 2019) Changed paths: M client/galaxy/scripts/mvc/ui/ui-color-picker.js Log Message: ----------- Drop unreachable code in colorpicker Commit: 8220705766dc3e23ddfbac45d887f82f8c36c85e https://github.com/galaxyproject/galaxy/commit/8220705766dc3e23ddfbac45d887f... Author: Dannon Baker <dannon.baker@gmail.com> Date: 2019-01-15 (Tue, 15 Jan 2019) Changed paths: M client/galaxy/scripts/mvc/ui/ui-color-picker.js Log Message: ----------- Fix color picker template (was missing a trailing div before, see previous commit), also fix inner definition of hex. Commit: f0205d4103b1a49466e58061a066852c360a51ea https://github.com/galaxyproject/galaxy/commit/f0205d4103b1a49466e58061a0668... Author: Dannon Baker <dannon.baker@gmail.com> Date: 2019-01-15 (Tue, 15 Jan 2019) Changed paths: M client/galaxy/scripts/mvc/history/history-content-model.js M client/galaxy/scripts/mvc/ui/icon-button.js M client/galaxy/scripts/mvc/ui/popup-menu.js Log Message: ----------- Fix noop catches, one final import in mvc. Commit: 56731df0f7ac43c6eaffe0c3a73ff685017973f6 https://github.com/galaxyproject/galaxy/commit/56731df0f7ac43c6eaffe0c3a73ff... Author: Dannon Baker <dannon.baker@gmail.com> Date: 2019-01-15 (Tue, 15 Jan 2019) Changed paths: M client/galaxy/scripts/mvc/library/library-foldertoolbar-view.js M client/galaxy/scripts/mvc/rules/rule-definitions.js M client/galaxy/scripts/mvc/ui/ui-buttons.js M client/galaxy/scripts/mvc/workflow/workflow-connector.js M client/galaxy/scripts/mvc/workflow/workflow-forms.js Log Message: ----------- Fix no-redeclares in scripts/mvc Commit: f410a461bbd5b43ac855ebd2de666fa5d9113c83 https://github.com/galaxyproject/galaxy/commit/f410a461bbd5b43ac855ebd2de666... Author: Dannon Baker <dannon.baker@gmail.com> Date: 2019-01-15 (Tue, 15 Jan 2019) Changed paths: M client/.eslintrc.js Log Message: ----------- Drop prettier plugin from eslint; we'll just run this -- no point in duplicating that check. Also set up a few rules that we can enable after the cleanup. Commit: 0a8edbb0643a00c1aabf643c6883fecff66e431f https://github.com/galaxyproject/galaxy/commit/0a8edbb0643a00c1aabf643c6883f... Author: Dannon Baker <dannon.baker@gmail.com> Date: 2019-01-15 (Tue, 15 Jan 2019) Changed paths: M client/galaxy/scripts/mvc/collection/collection-model.js Log Message: ----------- Fix bug in collection moodel toString -- this was always literally Commit: e69d540a8f28c5715822d432912d5c00d0c0ca81 https://github.com/galaxyproject/galaxy/commit/e69d540a8f28c5715822d432912d5... Author: Dannon Baker <dannon.baker@gmail.com> Date: 2019-01-15 (Tue, 15 Jan 2019) Changed paths: R client/galaxy/scripts/mvc/job/job-params.js Log Message: ----------- Remove inadvertently(?) added job-params file, looks to never have been used (and is mostly commented out code) Commit: 8004fad3e6614e24572d09648e40a88ece77b674 https://github.com/galaxyproject/galaxy/commit/8004fad3e6614e24572d09648e40a... Author: Dannon Baker <dannon.baker@gmail.com> Date: 2019-01-15 (Tue, 15 Jan 2019) Changed paths: M client/galaxy/scripts/mvc/library/library-foldertoolbar-view.js Log Message: ----------- Drop unused getGalaxyInstance in library-foldertoolbar -- these vars are templated in elsewhere, not pulled from the context. Commit: 639c9cecc0cef3a2da332f57ac8f7c63d44ee75d https://github.com/galaxyproject/galaxy/commit/639c9cecc0cef3a2da332f57ac8f7... Author: Dannon Baker <dannon.baker@gmail.com> Date: 2019-01-15 (Tue, 15 Jan 2019) Changed paths: M client/galaxy/scripts/mvc/collection/list-collection-creator.js M client/galaxy/scripts/mvc/dataset/dataset-list.js M client/galaxy/scripts/mvc/form/form-section.js M client/galaxy/scripts/mvc/history/hda-model.js M client/galaxy/scripts/mvc/history/hdca-model.js M client/galaxy/scripts/mvc/history/history-preferences.js M client/galaxy/scripts/mvc/history/history-view-annotated.js M client/galaxy/scripts/mvc/job/job-li.js M client/galaxy/scripts/mvc/lazy/lazy-limited.js M client/galaxy/scripts/mvc/library/library-folderrow-view.js M client/galaxy/scripts/mvc/tool/tool-form.js M client/galaxy/scripts/mvc/toolshed/repository-view.js M client/galaxy/scripts/mvc/ui/ui-list.js M client/galaxy/scripts/mvc/ui/ui-select-genomespace.js M client/galaxy/scripts/mvc/ui/ui-slider.js M client/galaxy/scripts/mvc/upload/collection/collection-row.js M client/galaxy/scripts/mvc/upload/collection/collection-view.js M client/galaxy/scripts/mvc/upload/composite/composite-row.js M client/galaxy/scripts/mvc/upload/default/default-row.js M client/galaxy/scripts/mvc/upload/upload-button.js M client/galaxy/scripts/mvc/upload/upload-extension.js M client/galaxy/scripts/mvc/upload/upload-settings.js M client/galaxy/scripts/mvc/user/user-model.js M client/galaxy/scripts/mvc/visualization/chart/utilities/series.js M client/galaxy/scripts/mvc/visualization/chart/views/editor.js M client/galaxy/scripts/mvc/visualization/chart/views/groups.js M client/galaxy/scripts/mvc/visualization/chart/views/menu.js M client/galaxy/scripts/mvc/workflow/workflow-connector.js M client/galaxy/scripts/mvc/workflow/workflow-node.js M client/galaxy/scripts/mvc/workflow/workflow-view-terminals.js Log Message: ----------- Fix final no-unused-vars for scripts/mvc Commit: 653452de56339c16017601fb5f5823bbe46771e8 https://github.com/galaxyproject/galaxy/commit/653452de56339c16017601fb5f582... Author: Dannon Baker <dannon.baker@gmail.com> Date: 2019-01-15 (Tue, 15 Jan 2019) Changed paths: M client/galaxy/scripts/layout/communication-server-view.js M client/galaxy/scripts/mvc/grid/grid-template.js M client/galaxy/scripts/mvc/history/hdca-li-edit.js M client/galaxy/scripts/mvc/library/library-dataset-view.js M client/galaxy/scripts/mvc/library/library-foldertoolbar-view.js M client/galaxy/scripts/mvc/toolshed/repo-status-view.js M client/galaxy/scripts/mvc/ui/ui-buttons.js M client/galaxy/scripts/mvc/ui/ui-options.js M client/galaxy/scripts/mvc/ui/ui-popover.js M client/galaxy/scripts/mvc/ui/ui-tabs.js M client/galaxy/scripts/mvc/user/user-quotameter.js M client/galaxy/scripts/mvc/workflow/workflow-canvas.js M client/galaxy/scripts/reports/run_stats.js M client/galaxy/scripts/ui/autocom_tagging.js M client/galaxy/scripts/ui/pagination.js M client/galaxy/scripts/ui/peek-column-selector.js M client/galaxy/scripts/viz/phyloviz.js Log Message: ----------- Drop /* global blah */ directives, correctly supply sources for $, Galaxy, and more. Left out test dir and google analytics references. Commit: d30b7dfbe0aba80b7d14446f208a395f2f1e7a61 https://github.com/galaxyproject/galaxy/commit/d30b7dfbe0aba80b7d14446f208a3... Author: Dannon Baker <dannon.baker@gmail.com> Date: 2019-01-15 (Tue, 15 Jan 2019) Changed paths: M client/galaxy/scripts/layout/communication-server-view.js M client/galaxy/scripts/mvc/grid/grid-template.js M client/galaxy/scripts/mvc/history/hdca-li-edit.js M client/galaxy/scripts/mvc/toolshed/repo-status-view.js M client/galaxy/scripts/mvc/toolshed/shed-list-view.js M client/galaxy/scripts/mvc/ui/ui-buttons.js M client/galaxy/scripts/mvc/ui/ui-options.js M client/galaxy/scripts/mvc/ui/ui-popover.js M client/galaxy/scripts/mvc/ui/ui-select.js M client/galaxy/scripts/mvc/ui/ui-tabs.js M client/galaxy/scripts/mvc/user/user-quotameter.js M client/galaxy/scripts/mvc/visualization/chart/components/model.js M client/galaxy/scripts/mvc/visualization/chart/utilities/series.js M client/galaxy/scripts/mvc/workflow/workflow-view-node.js M client/galaxy/scripts/ui/fa-icon-button.js M client/galaxy/scripts/viz/trackster/filters.js M client/galaxy/scripts/viz/trackster/painters.js M client/galaxy/scripts/viz/trackster/slotting.js Log Message: ----------- Standardize backbone and underscore imports. Commit: 140d53f56477feeac1368cd662e4e13e4f8b0dcd https://github.com/galaxyproject/galaxy/commit/140d53f56477feeac1368cd662e4e... Author: Dannon Baker <dannon.baker@gmail.com> Date: 2019-01-15 (Tue, 15 Jan 2019) Changed paths: A client/.eslintignore M client/.eslintrc.js M client/package.json Log Message: ----------- Enable vue linting and include verything but galaxy/scripts/libs Commit: 62a65c448266ffae47ec72da087861bdbe14d433 https://github.com/galaxyproject/galaxy/commit/62a65c448266ffae47ec72da08786... Author: Dannon Baker <dannon.baker@gmail.com> Date: 2019-01-15 (Tue, 15 Jan 2019) Changed paths: M client/galaxy/scripts/components/Citations.vue M client/galaxy/scripts/components/DataDialog.vue M client/galaxy/scripts/components/DisplayStructured.vue M client/galaxy/scripts/components/HistoryView.vue M client/galaxy/scripts/components/PluginList.vue M client/galaxy/scripts/components/RuleCollectionBuilder.vue M client/galaxy/scripts/components/RulesDisplay.vue M client/galaxy/scripts/components/Sharing.vue Log Message: ----------- Fix most of the non-vue-specific linting issues in components Commit: 6e1f1eca44c93be02972896d44d69793f154b948 https://github.com/galaxyproject/galaxy/commit/6e1f1eca44c93be02972896d44d69... Author: Dannon Baker <dannon.baker@gmail.com> Date: 2019-01-15 (Tue, 15 Jan 2019) Changed paths: M client/.eslintignore Log Message: ----------- Add tests, legacy, nls to eslintignore for now. Commit: 8e465b36b7c747c3a5dc336339bccd2111ec0aea https://github.com/galaxyproject/galaxy/commit/8e465b36b7c747c3a5dc336339bcc... Author: Dannon Baker <dannon.baker@gmail.com> Date: 2019-01-15 (Tue, 15 Jan 2019) Changed paths: M client/.eslintignore Log Message: ----------- Ignore .test.js files Commit: 3256849f683109c4831e36e5c30465d5d56858cb https://github.com/galaxyproject/galaxy/commit/3256849f683109c4831e36e5c3046... Author: Dannon Baker <dannon.baker@gmail.com> Date: 2019-01-15 (Tue, 15 Jan 2019) Changed paths: M client/.eslintignore Log Message: ----------- Ignore scripts/toolshed in linting -- we're dropping all this (I think?) from the repo. Commit: ac0d027b2517e1fb2011ba75fb5879a6b682963e https://github.com/galaxyproject/galaxy/commit/ac0d027b2517e1fb2011ba75fb587... Author: Dannon Baker <dannon.baker@gmail.com> Date: 2019-01-15 (Tue, 15 Jan 2019) Changed paths: M client/galaxy/scripts/utils/ajax-queue.js M client/galaxy/scripts/utils/graph.js M client/galaxy/scripts/utils/localization.js M client/galaxy/scripts/utils/natural-sort.js M client/galaxy/scripts/utils/query-string-parsing.js M client/galaxy/scripts/utils/utils.js Log Message: ----------- Cleanup in galaxy/scripts/utils Commit: aede1ab2befaf89a9c002fca69d8310b7ad7f130 https://github.com/galaxyproject/galaxy/commit/aede1ab2befaf89a9c002fca69d83... Author: Dannon Baker <dannon.baker@gmail.com> Date: 2019-01-15 (Tue, 15 Jan 2019) Changed paths: M client/.eslintignore M client/galaxy/scripts/toolshed/groups/group-detail-view.js M client/galaxy/scripts/toolshed/groups/group-list-view.js M client/galaxy/scripts/toolshed/groups/group-listrow-view.js M client/galaxy/scripts/toolshed/toolshed.groups.js Log Message: ----------- Add scripts/toolshed back to eslint; go ahead and fix the straightforward import issues Commit: 756ff01a5328c53dac7aafe90c77506de516cd9e https://github.com/galaxyproject/galaxy/commit/756ff01a5328c53dac7aafe90c775... Author: Dannon Baker <dannon.baker@gmail.com> Date: 2019-01-15 (Tue, 15 Jan 2019) Changed paths: M client/galaxy/scripts/viz/bbi-data-manager.js M client/galaxy/scripts/viz/phyloviz.js M client/galaxy/scripts/viz/sweepster.js M client/galaxy/scripts/viz/trackster/filters.js M client/galaxy/scripts/viz/trackster/util.js M client/galaxy/scripts/viz/visualization.js Log Message: ----------- Cleanup in galaxy/scripts/viz, lints cleanly with one exception that I do not understand. Commit: 9316659b12b13f827d0ca24c75a1fd85075c6135 https://github.com/galaxyproject/galaxy/commit/9316659b12b13f827d0ca24c75a1f... Author: Dannon Baker <dannon.baker@gmail.com> Date: 2019-01-15 (Tue, 15 Jan 2019) Changed paths: M client/galaxy/scripts/ui/autocom_tagging.js M client/galaxy/scripts/ui/filter-control.js M client/galaxy/scripts/ui/mode-button.js M client/galaxy/scripts/ui/popupmenu.js M client/galaxy/scripts/ui/scroll-panel.js Log Message: ----------- Cleanup in galaxy/scripts/ui, lints cleanly now. Commit: be943ef6331ee7c469cdd423c764e8b2107e581a https://github.com/galaxyproject/galaxy/commit/be943ef6331ee7c469cdd423c764e... Author: Dannon Baker <dannon.baker@gmail.com> Date: 2019-01-15 (Tue, 15 Jan 2019) Changed paths: M client/galaxy/scripts/galaxy.interactive_environments.js Log Message: ----------- Document global usage and nonstandard bundling for galaxy.interactive_environments Commit: 441e5bb93b6be6571959613aacd5f9434168ffde https://github.com/galaxyproject/galaxy/commit/441e5bb93b6be6571959613aacd5f... Author: Dannon Baker <dannon.baker@gmail.com> Date: 2019-01-15 (Tue, 15 Jan 2019) Changed paths: M client/galaxy/scripts/app/galaxy.js M client/galaxy/scripts/entry/admin/index.js M client/galaxy/scripts/i18n.js M client/galaxy/scripts/layout/data.js M client/galaxy/scripts/polyfills.js M client/galaxy/scripts/unitTestBundle.js Log Message: ----------- Fix final standalone file linting issues. Component-specific issues remain. Commit: 86d728ab98128b6995db3c354229a5dd2dd14b00 https://github.com/galaxyproject/galaxy/commit/86d728ab98128b6995db3c354229a... Author: Dannon Baker <dannon.baker@gmail.com> Date: 2019-01-15 (Tue, 15 Jan 2019) Changed paths: M client/galaxy/scripts/components/Alert.vue M client/galaxy/scripts/components/Citations.vue M client/galaxy/scripts/components/DataDialog.vue M client/galaxy/scripts/components/DisplayStructured.vue M client/galaxy/scripts/components/GalaxyLoader.vue M client/galaxy/scripts/components/HistoryImport.vue M client/galaxy/scripts/components/HistoryView.vue M client/galaxy/scripts/components/Masthead/index.vue M client/galaxy/scripts/components/Message.vue M client/galaxy/scripts/components/PluginList.vue M client/galaxy/scripts/components/RuleCollectionBuilder.vue M client/galaxy/scripts/components/RulesDisplay.vue M client/galaxy/scripts/components/Sharing.vue M client/galaxy/scripts/components/WorkflowImport.vue M client/galaxy/scripts/components/admin/BaseGrid.vue M client/galaxy/scripts/components/admin/DataManager/DataManager.vue M client/galaxy/scripts/components/admin/DataManager/DataManagerJob.vue M client/galaxy/scripts/components/admin/DataManager/DataManagerJobs.vue M client/galaxy/scripts/components/admin/DataManager/DataManagerTable.vue M client/galaxy/scripts/components/admin/DataManager/DataManagerView.vue M client/galaxy/scripts/components/admin/DataManagerGrid.vue M client/galaxy/scripts/components/admin/DataTables.vue M client/galaxy/scripts/components/admin/DataTablesGrid.vue M client/galaxy/scripts/components/admin/DataTypes.vue M client/galaxy/scripts/components/admin/DisplayApplications.vue M client/galaxy/scripts/components/admin/ErrorStack.vue M client/galaxy/scripts/galaxy.interactive_environments.js M client/galaxy/scripts/legacy/grid/grid-view.js M client/galaxy/scripts/mvc/grid/grid-view.js M client/galaxy/scripts/mvc/history/copy-dialog.js M client/galaxy/scripts/mvc/tool/tools.js M client/galaxy/scripts/mvc/ui/ui-color-picker.js M client/galaxy/scripts/mvc/user/user-quotameter.js M client/galaxy/scripts/ui/filter-control.js M client/galaxy/scripts/ui/peek-column-selector.js M client/galaxy/scripts/ui/scroll-panel.js M client/galaxy/scripts/utils/localization.js M client/galaxy/scripts/utils/metrics-logger.js M client/galaxy/scripts/viz/circster.js M client/galaxy/scripts/viz/phyloviz.js M client/galaxy/scripts/viz/sweepster.js M client/galaxy/scripts/viz/trackster/filters.js M client/galaxy/scripts/viz/trackster/painters.js M client/galaxy/scripts/viz/trackster/tracks.js M client/galaxy/scripts/viz/visualization.js Log Message: ----------- Run updated and now successfully passing Prettier. Commit: 917fc8702f1a6d8d8403c924b90ad2186429b9e1 https://github.com/galaxyproject/galaxy/commit/917fc8702f1a6d8d8403c924b90ad... Author: Dannon Baker <dannon.baker@gmail.com> Date: 2019-01-15 (Tue, 15 Jan 2019) Changed paths: M client/galaxy/scripts/app/galaxy.js Log Message: ----------- This is way too chatty to log Commit: 08b4bc2ae9dbcc78561f72517047ea2e9aa71a38 https://github.com/galaxyproject/galaxy/commit/08b4bc2ae9dbcc78561f72517047e... Author: Dannon Baker <dannon.baker@gmail.com> Date: 2019-01-15 (Tue, 15 Jan 2019) Changed paths: M client/galaxy/scripts/utils/localization.js Log Message: ----------- next-line is more reliable... prettier broke the disable-line comment that was previously here Commit: c3cf826565464ad58ef9c65e99d83cd8fe9bc916 https://github.com/galaxyproject/galaxy/commit/c3cf826565464ad58ef9c65e99d83... Author: Dannon Baker <dannon.baker@gmail.com> Date: 2019-01-15 (Tue, 15 Jan 2019) Changed paths: M client/galaxy/scripts/components/Sharing.vue Log Message: ----------- Drop one more unnecessary escape, this time in Sharing.vue Commit: 1c1c37c23ccd4619317d49ece3543e34e5ab06ab https://github.com/galaxyproject/galaxy/commit/1c1c37c23ccd4619317d49ece3543... Author: Dannon Baker <dannon.baker@gmail.com> Date: 2019-01-15 (Tue, 15 Jan 2019) Changed paths: M client/galaxy/scripts/components/DataDialog.vue Log Message: ----------- Drop modalTitle (display is busted and it's unused/redundant, so I think this was unintentional -- also lacks a default value for the computed prop) Commit: 44b020e852ac34ec1102c511cf5c482109ca1674 https://github.com/galaxyproject/galaxy/commit/44b020e852ac34ec1102c511cf5c4... Author: Dannon Baker <dannon.baker@gmail.com> Date: 2019-01-15 (Tue, 15 Jan 2019) Changed paths: M client/package.json Log Message: ----------- With eslintignore in the right spot, we don't need to specify this path. Commit: 07334d5adb74c5d654b3eb45a34e79da8ea7939b https://github.com/galaxyproject/galaxy/commit/07334d5adb74c5d654b3eb45a34e7... Author: Dannon Baker <dannon.baker@gmail.com> Date: 2019-01-15 (Tue, 15 Jan 2019) Changed paths: M client/galaxy/scripts/components/DisplayStructured.vue Log Message: ----------- Drop unnecessary key, after reading more about how v-for key indexes are used. Commit: f349e5f56e06f84ecc948b348528629e82e749b4 https://github.com/galaxyproject/galaxy/commit/f349e5f56e06f84ecc948b3485286... Author: Dannon Baker <dannon.baker@gmail.com> Date: 2019-01-15 (Tue, 15 Jan 2019) Changed paths: M client/galaxy/scripts/components/DisplayStructured.vue Log Message: ----------- We'll want to look at each usage of these and document them as skippable or (likely) use an appropriate index for iteration. Commit: f576cd5494233cfbcc9d4d51ced02014049449a8 https://github.com/galaxyproject/galaxy/commit/f576cd5494233cfbcc9d4d51ced02... Author: Dannon Baker <dannon.baker@gmail.com> Date: 2019-01-15 (Tue, 15 Jan 2019) Changed paths: M client/galaxy/scripts/components/PluginList.vue Log Message: ----------- Use appropriate keys for plugin list iteration. Commit: 3b9857d7b7de716077eaa20ca2468aa41a7d932b https://github.com/galaxyproject/galaxy/commit/3b9857d7b7de716077eaa20ca2468... Author: Dannon Baker <dannon.baker@gmail.com> Date: 2019-01-15 (Tue, 15 Jan 2019) Changed paths: M client/galaxy/scripts/components/HistoryView.vue M client/galaxy/scripts/components/admin/BaseGrid.vue M client/galaxy/scripts/components/admin/DataManagerGrid.vue M client/galaxy/scripts/components/admin/DataTablesGrid.vue M client/galaxy/scripts/components/admin/DisplayApplications.vue Log Message: ----------- Address require-v-for-key as appropriate, either documenting a skip for simple iteration or indexing for keyed objects Commit: 2924f1fda1554416bfa81258874aef52329c971b https://github.com/galaxyproject/galaxy/commit/2924f1fda1554416bfa81258874ae... Author: Dannon Baker <dannon.baker@gmail.com> Date: 2019-01-15 (Tue, 15 Jan 2019) Changed paths: M client/galaxy/scripts/components/DisplayStructured.vue M client/galaxy/scripts/components/HistoryView.vue M client/galaxy/scripts/components/PluginList.vue M client/galaxy/scripts/components/RuleCollectionBuilder.vue M client/galaxy/scripts/components/admin/BaseGrid.vue Log Message: ----------- Fix remaining straightforward-ish linting issues. Two remaining errors -- a side effect in RuleBuilder's hotData and the trackster filter issue. Commit: 875dab36edb5dee20e563d847b2e9bd7b7258cc0 https://github.com/galaxyproject/galaxy/commit/875dab36edb5dee20e563d847b2e9... Author: Dannon Baker <dannon.baker@gmail.com> Date: 2019-01-15 (Tue, 15 Jan 2019) Changed paths: M client/galaxy/scripts/qunit/tests/form_tests.js M client/galaxy/style/scss/theme/blue.scss Log Message: ----------- Run prettier after rebase Commit: f95cff627bd64c6dba446128617e94037132d2e7 https://github.com/galaxyproject/galaxy/commit/f95cff627bd64c6dba446128617e9... Author: Dannon Baker <dannon.baker@gmail.com> Date: 2019-01-15 (Tue, 15 Jan 2019) Changed paths: M Makefile M tox.ini Log Message: ----------- Attempt to add eslint to travis. Commit: 6a4297a9fc4320fdfcda59385ad6fc6a2cb546da https://github.com/galaxyproject/galaxy/commit/6a4297a9fc4320fdfcda59385ad6f... Author: Dannon Baker <dannon.baker@gmail.com> Date: 2019-01-15 (Tue, 15 Jan 2019) Changed paths: M .travis.yml Log Message: ----------- Tox works, add eslint to travis.yml Commit: 7b97bd3e1b97d02be8288bae0767ebbcde2c188e https://github.com/galaxyproject/galaxy/commit/7b97bd3e1b97d02be8288bae0767e... Author: Dannon Baker <dannon.baker@gmail.com> Date: 2019-01-15 (Tue, 15 Jan 2019) Changed paths: M .travis.yml Log Message: ----------- Test specifying node version in travis config Commit: 588e2d7460c74a103a8075a93fdfe6aab4d71ad5 https://github.com/galaxyproject/galaxy/commit/588e2d7460c74a103a8075a93fdfe... Author: Dannon Baker <dannon.baker@gmail.com> Date: 2019-01-15 (Tue, 15 Jan 2019) Changed paths: M .travis.yml M tox.ini Log Message: ----------- Test building without tox Commit: 61774f5126c9eab5e3fe42e3b1cde1d12e5bf1b0 https://github.com/galaxyproject/galaxy/commit/61774f5126c9eab5e3fe42e3b1cde... Author: Dannon Baker <dannon.baker@gmail.com> Date: 2019-01-15 (Tue, 15 Jan 2019) Changed paths: M .travis.yml M Makefile M tox.ini Log Message: ----------- re-enable full matrix, overhaul qunit/lint implementations. Commit: b8347c0fb1729500002dfa272758ac62d8f2c3d0 https://github.com/galaxyproject/galaxy/commit/b8347c0fb1729500002dfa272758a... Author: Dannon Baker <dannon.baker@gmail.com> Date: 2019-01-15 (Tue, 15 Jan 2019) Changed paths: M .travis.yml Log Message: ----------- Test adding a qunit js env Commit: 19af921845050d708a1bcc56882fa77cd2a1dc1e https://github.com/galaxyproject/galaxy/commit/19af921845050d708a1bcc56882fa... Author: Dannon Baker <dannon.baker@gmail.com> Date: 2019-01-15 (Tue, 15 Jan 2019) Changed paths: M .travis.yml Log Message: ----------- DRop js primary env, use specific defs in matrix Commit: 4986f62a8d14601c1eafb584a766e99180ca7577 https://github.com/galaxyproject/galaxy/commit/4986f62a8d14601c1eafb584a766e... Author: Dannon Baker <dannon.baker@gmail.com> Date: 2019-01-15 (Tue, 15 Jan 2019) Changed paths: M .travis.yml Log Message: ----------- qunit actually needs a build, because of base.css... (we should really fix this, should not be required) Commit: 2025eab2184750611338600a1f22828b15847707 https://github.com/galaxyproject/galaxy/commit/2025eab2184750611338600a1f228... Author: Dannon Baker <dannon.baker@gmail.com> Date: 2019-01-16 (Wed, 16 Jan 2019) Changed paths: M .travis.yml Log Message: ----------- Use 'name' in the travis build matrix instead of env for javascript jobs Commit: 9ddcba91be81fcb7265c6fd449d4dc2a2825d647 https://github.com/galaxyproject/galaxy/commit/9ddcba91be81fcb7265c6fd449d4d... Author: Dannon Baker <dannon.baker@gmail.com> Date: 2019-01-16 (Wed, 16 Jan 2019) Changed paths: M Makefile Log Message: ----------- Drop internal client-test-* makefile targets Commit: b50e87ff2888ecac672740b0f68216ab8245736b https://github.com/galaxyproject/galaxy/commit/b50e87ff2888ecac672740b0f6821... Author: Dannon Baker <dannon.baker@gmail.com> Date: 2019-01-16 (Wed, 16 Jan 2019) Changed paths: M .travis.yml Log Message: ----------- Better names for js travis jobs Commit: 92323e05d64f6d50caa6ca57f6061ba387d77017 https://github.com/galaxyproject/galaxy/commit/92323e05d64f6d50caa6ca57f6061... Author: Dannon Baker <dannon.baker@gmail.com> Date: 2019-01-16 (Wed, 16 Jan 2019) Changed paths: M client/galaxy/scripts/viz/trackster/filters.js Log Message: ----------- Document eslint exception, create issue for trackster filter/group functionality not working. Commit: a482c5ce4cd70b208f07e79eb0f5c08ec1e67292 https://github.com/galaxyproject/galaxy/commit/a482c5ce4cd70b208f07e79eb0f5c... Author: Dannon Baker <dannon.baker@gmail.com> Date: 2019-01-16 (Wed, 16 Jan 2019) Changed paths: M client/galaxy/scripts/components/RuleCollectionBuilder.vue Log Message: ----------- Swap hotData() from a computed property to a method, since it has side effects. see https://github.com/vuejs/eslint-plugin-vue/blob/master/docs/rules/no-side-ef... and https://vuejs.org/v2/guide/computed.html#Computed-Caching-vs-Methods Commit: 8cd8a03284e710d7b8bedc2244c13087941dfa89 https://github.com/galaxyproject/galaxy/commit/8cd8a03284e710d7b8bedc2244c13... Author: Dannon Baker <dannon.baker@gmail.com> Date: 2019-01-16 (Wed, 16 Jan 2019) Changed paths: M client/galaxy/scripts/components/Sharing.vue M config/galaxy.yml.sample M config/reports.yml.sample M config/tool_shed.yml.sample M doc/source/admin/galaxy_options.rst M doc/source/admin/reports_options.rst M lib/galaxy/dependencies/__init__.py M lib/galaxy/dependencies/conditional-requirements.txt M lib/galaxy/webapps/galaxy/config_schema.yml M lib/galaxy/webapps/reports/config_schema.yml M lib/galaxy/webapps/tool_shed/config_schema.yml Log Message: ----------- Merge remote-tracking branch 'upstream/dev' into eslint, resolving conflict in "Sharing.vue" Commit: f8b87d988c965a04806adf7ff9dccf3a41f52d86 https://github.com/galaxyproject/galaxy/commit/f8b87d988c965a04806adf7ff9dcc... Author: Aysam Guerler <aysam.guerler@gmail.com> Date: 2019-01-16 (Wed, 16 Jan 2019) Changed paths: M .travis.yml M Makefile A client/.eslintignore A client/.eslintrc.js M client/galaxy/scripts/app/galaxy.js M client/galaxy/scripts/components/Alert.vue M client/galaxy/scripts/components/Citations.vue M client/galaxy/scripts/components/DataDialog.vue M client/galaxy/scripts/components/DisplayStructured.vue M client/galaxy/scripts/components/GalaxyLoader.vue M client/galaxy/scripts/components/HistoryImport.vue M client/galaxy/scripts/components/HistoryView.vue M client/galaxy/scripts/components/Masthead/index.vue M client/galaxy/scripts/components/Message.vue M client/galaxy/scripts/components/PluginList.vue M client/galaxy/scripts/components/RuleCollectionBuilder.vue M client/galaxy/scripts/components/RulesDisplay.vue M client/galaxy/scripts/components/Sharing.vue M client/galaxy/scripts/components/WorkflowImport.vue M client/galaxy/scripts/components/admin/BaseGrid.vue M client/galaxy/scripts/components/admin/DataManager/DataManager.vue M client/galaxy/scripts/components/admin/DataManager/DataManagerJob.vue M client/galaxy/scripts/components/admin/DataManager/DataManagerJobs.vue M client/galaxy/scripts/components/admin/DataManager/DataManagerTable.vue M client/galaxy/scripts/components/admin/DataManager/DataManagerView.vue M client/galaxy/scripts/components/admin/DataManagerGrid.vue M client/galaxy/scripts/components/admin/DataTables.vue M client/galaxy/scripts/components/admin/DataTablesGrid.vue M client/galaxy/scripts/components/admin/DataTypes.vue M client/galaxy/scripts/components/admin/DisplayApplications.vue M client/galaxy/scripts/components/admin/ErrorStack.vue M client/galaxy/scripts/entry/admin/index.js M client/galaxy/scripts/galaxy.interactive_environments.js M client/galaxy/scripts/i18n.js M client/galaxy/scripts/layout/communication-server-view.js M client/galaxy/scripts/layout/data.js M client/galaxy/scripts/legacy/grid/grid-view.js M client/galaxy/scripts/mvc/annotation.js M client/galaxy/scripts/mvc/base-mvc.js M client/galaxy/scripts/mvc/collection/base-creator.js M client/galaxy/scripts/mvc/collection/collection-li-edit.js M client/galaxy/scripts/mvc/collection/collection-model.js M client/galaxy/scripts/mvc/collection/collection-view-edit.js M client/galaxy/scripts/mvc/collection/list-collection-creator.js M client/galaxy/scripts/mvc/collection/list-of-pairs-collection-creator.js M client/galaxy/scripts/mvc/collection/pair-collection-creator.js M client/galaxy/scripts/mvc/dataset/data.js M client/galaxy/scripts/mvc/dataset/dataset-choice.js M client/galaxy/scripts/mvc/dataset/dataset-list.js M client/galaxy/scripts/mvc/form/form-input.js M client/galaxy/scripts/mvc/form/form-parameters.js M client/galaxy/scripts/mvc/form/form-section.js M client/galaxy/scripts/mvc/form/form-view.js M client/galaxy/scripts/mvc/grid/grid-model.js M client/galaxy/scripts/mvc/grid/grid-template.js M client/galaxy/scripts/mvc/grid/grid-view.js M client/galaxy/scripts/mvc/history/copy-dialog.js M client/galaxy/scripts/mvc/history/hda-li-edit.js M client/galaxy/scripts/mvc/history/hda-li.js M client/galaxy/scripts/mvc/history/hda-model.js M client/galaxy/scripts/mvc/history/hdca-li-edit.js M client/galaxy/scripts/mvc/history/hdca-model.js M client/galaxy/scripts/mvc/history/history-content-model.js M client/galaxy/scripts/mvc/history/history-item-li.js M client/galaxy/scripts/mvc/history/history-preferences.js M client/galaxy/scripts/mvc/history/history-view-annotated.js M client/galaxy/scripts/mvc/history/job-dag.js M client/galaxy/scripts/mvc/history/options-menu.js M client/galaxy/scripts/mvc/job/job-li.js R client/galaxy/scripts/mvc/job/job-params.js M client/galaxy/scripts/mvc/lazy/lazy-limited.js M client/galaxy/scripts/mvc/library/library-dataset-view.js M client/galaxy/scripts/mvc/library/library-folderrow-view.js M client/galaxy/scripts/mvc/library/library-foldertoolbar-view.js M client/galaxy/scripts/mvc/library/library-librarylist-view.js M client/galaxy/scripts/mvc/rules/rule-definitions.js M client/galaxy/scripts/mvc/tool/tool-form-composite.js M client/galaxy/scripts/mvc/tool/tool-form.js M client/galaxy/scripts/mvc/tool/tool-genomespace.js M client/galaxy/scripts/mvc/tool/tools.js M client/galaxy/scripts/mvc/toolshed/repo-status-view.js M client/galaxy/scripts/mvc/toolshed/repository-view.js M client/galaxy/scripts/mvc/toolshed/shed-list-view.js M client/galaxy/scripts/mvc/ui/icon-button.js M client/galaxy/scripts/mvc/ui/popup-menu.js M client/galaxy/scripts/mvc/ui/ui-buttons.js M client/galaxy/scripts/mvc/ui/ui-color-picker.js M client/galaxy/scripts/mvc/ui/ui-drilldown.js M client/galaxy/scripts/mvc/ui/ui-list.js M client/galaxy/scripts/mvc/ui/ui-misc.js M client/galaxy/scripts/mvc/ui/ui-modal.js M client/galaxy/scripts/mvc/ui/ui-options.js M client/galaxy/scripts/mvc/ui/ui-popover.js M client/galaxy/scripts/mvc/ui/ui-portlet.js M client/galaxy/scripts/mvc/ui/ui-select-default.js M client/galaxy/scripts/mvc/ui/ui-select-genomespace.js M client/galaxy/scripts/mvc/ui/ui-select.js M client/galaxy/scripts/mvc/ui/ui-slider.js M client/galaxy/scripts/mvc/ui/ui-table.js M client/galaxy/scripts/mvc/ui/ui-tabs.js M client/galaxy/scripts/mvc/upload/collection/collection-row.js M client/galaxy/scripts/mvc/upload/collection/collection-view.js M client/galaxy/scripts/mvc/upload/composite/composite-row.js M client/galaxy/scripts/mvc/upload/default/default-row.js M client/galaxy/scripts/mvc/upload/upload-button.js M client/galaxy/scripts/mvc/upload/upload-extension.js M client/galaxy/scripts/mvc/upload/upload-model.js M client/galaxy/scripts/mvc/upload/upload-settings.js M client/galaxy/scripts/mvc/user/user-model.js M client/galaxy/scripts/mvc/user/user-quotameter.js M client/galaxy/scripts/mvc/visualization/chart/components/model.js M client/galaxy/scripts/mvc/visualization/chart/components/screenshot.js M client/galaxy/scripts/mvc/visualization/chart/utilities/series.js M client/galaxy/scripts/mvc/visualization/chart/views/editor.js M client/galaxy/scripts/mvc/visualization/chart/views/groups.js M client/galaxy/scripts/mvc/visualization/chart/views/menu.js M client/galaxy/scripts/mvc/visualization/chart/views/settings.js M client/galaxy/scripts/mvc/visualization/chart/views/viewer.js M client/galaxy/scripts/mvc/workflow/workflow-canvas.js M client/galaxy/scripts/mvc/workflow/workflow-connector.js M client/galaxy/scripts/mvc/workflow/workflow-forms.js M client/galaxy/scripts/mvc/workflow/workflow-node.js M client/galaxy/scripts/mvc/workflow/workflow-terminals.js M client/galaxy/scripts/mvc/workflow/workflow-view-node.js M client/galaxy/scripts/mvc/workflow/workflow-view-terminals.js M client/galaxy/scripts/polyfills.js M client/galaxy/scripts/qunit/tests/form_tests.js M client/galaxy/scripts/reports/run_stats.js M client/galaxy/scripts/toolshed/groups/group-detail-view.js M client/galaxy/scripts/toolshed/groups/group-list-view.js M client/galaxy/scripts/toolshed/groups/group-listrow-view.js M client/galaxy/scripts/toolshed/toolshed.groups.js M client/galaxy/scripts/ui/autocom_tagging.js M client/galaxy/scripts/ui/fa-icon-button.js M client/galaxy/scripts/ui/filter-control.js M client/galaxy/scripts/ui/mode-button.js M client/galaxy/scripts/ui/pagination.js M client/galaxy/scripts/ui/peek-column-selector.js M client/galaxy/scripts/ui/popupmenu.js M client/galaxy/scripts/ui/scroll-panel.js M client/galaxy/scripts/unitTestBundle.js M client/galaxy/scripts/utils/ajax-queue.js M client/galaxy/scripts/utils/graph.js M client/galaxy/scripts/utils/localization.js M client/galaxy/scripts/utils/metrics-logger.js M client/galaxy/scripts/utils/natural-sort.js M client/galaxy/scripts/utils/query-string-parsing.js M client/galaxy/scripts/utils/utils.js M client/galaxy/scripts/viz/bbi-data-manager.js M client/galaxy/scripts/viz/circster.js M client/galaxy/scripts/viz/phyloviz.js M client/galaxy/scripts/viz/sweepster.js M client/galaxy/scripts/viz/trackster/filters.js M client/galaxy/scripts/viz/trackster/painters.js M client/galaxy/scripts/viz/trackster/slotting.js M client/galaxy/scripts/viz/trackster/tracks.js M client/galaxy/scripts/viz/trackster/util.js M client/galaxy/scripts/viz/visualization.js M client/galaxy/style/scss/base.scss M client/galaxy/style/scss/theme/blue.scss M client/package.json A client/prettier.config.js M client/yarn.lock M tox.ini Log Message: ----------- Merge pull request #7202 from dannon/eslint Eslint Compare: https://github.com/galaxyproject/galaxy/compare/10c2f9cbc286...f8b87d988c96 **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.