Branch: refs/heads/dev Home: https://github.com/galaxyproject/galaxy Commit: 1f0ec9424fd116a1f6896bf648d16a309f1e6847 https://github.com/galaxyproject/galaxy/commit/1f0ec9424fd116a1f6896bf648d16... Author: mvdbeek m.vandenbeek@gmail.com Date: 2019-03-04 (Mon, 04 Mar 2019)

Changed paths: M lib/galaxy/tools/cache.py M test/unit/tools/test_toolbox.py

Log Message: ----------- Use a lock on cleanup, expire_tool and cache_tool

This should fix https://github.com/galaxyproject/galaxy/issues/7444.

Commit: 2d7b3e32d300ba33b0dadd3b8ff1cbec6b98a9bb https://github.com/galaxyproject/galaxy/commit/2d7b3e32d300ba33b0dadd3b8ff1c... Author: Nicola Soranzo nicola.soranzo@earlham.ac.uk Date: 2019-03-04 (Mon, 04 Mar 2019)

Changed paths: M lib/galaxy/tools/cache.py M test/unit/tools/test_toolbox.py

Log Message: ----------- Add debugging statements to ``ToolCache.cleanup()``

Commit: d3652f871a59e1dc9be40aaea693fb4219dbb48c https://github.com/galaxyproject/galaxy/commit/d3652f871a59e1dc9be40aaea693f... Author: Nicola Soranzo nicola.soranzo@earlham.ac.uk Date: 2019-03-04 (Mon, 04 Mar 2019)

Changed paths: M lib/galaxy/tools/cache.py

Log Message: ----------- Use lock also for ``ToolCache.reset_status()`` method

Commit: 294c7b6eebfb02f947697111c82033b3ba68be04 https://github.com/galaxyproject/galaxy/commit/294c7b6eebfb02f947697111c8203... Author: Nicola Soranzo nicola.soranzo@earlham.ac.uk Date: 2019-03-04 (Mon, 04 Mar 2019)

Changed paths: M test/unit/tools/test_toolbox.py

Log Message: ----------- Use ``_try_until_no_errors`` also for ``test_tool_reload_when_macro_is_altered`` unit test

Commit: 999c2c038e850a75d5fce0030bdcdbcf3bf0b13d https://github.com/galaxyproject/galaxy/commit/999c2c038e850a75d5fce0030bdcd... Author: mvdbeek m.vandenbeek@gmail.com Date: 2019-03-04 (Mon, 04 Mar 2019)

Changed paths: M test/unit/tools/test_toolbox.py

Log Message: ----------- Store toolbox in test_case._toolbox

Apparently accessing double-underscore variables in threads leads to name-mangling issues, so effectively updating test_case.__toolbox wouldn't be reflected outside of the watcher thread. We previously used self.app.toolbox which circumenvented this issue. It is possible that `check_tool_errors` / `check_no_tool_errors` were accessing the old toolbox, unless the watching thread happened to fire between function definition and assert, and that's probably why increasing the number of trials had no effect.

Commit: b84607728d7754347de94a1787f00e5a96cebde1 https://github.com/galaxyproject/galaxy/commit/b84607728d7754347de94a1787f00... Author: mvdbeek m.vandenbeek@gmail.com Date: 2019-03-04 (Mon, 04 Mar 2019)

Changed paths: M test/unit/tools/test_toolbox.py

Log Message: ----------- Tear down started threads

Commit: c1f8221b0bd9e8235a24d387990586b9dbbcb21c https://github.com/galaxyproject/galaxy/commit/c1f8221b0bd9e8235a24d38799058... Author: mvdbeek m.vandenbeek@gmail.com Date: 2019-03-04 (Mon, 04 Mar 2019)

Changed paths: M test/unit/tools_support.py

Log Message: ----------- Use ``with`` statement

Commit: f9df69d5f2d58d86a4b0c834bb55e7debcec8707 https://github.com/galaxyproject/galaxy/commit/f9df69d5f2d58d86a4b0c834bb55e... Author: Nicola Soranzo nicola.soranzo@gmail.com Date: 2019-03-04 (Mon, 04 Mar 2019)

Changed paths: M lib/galaxy/tools/cache.py M test/unit/tools/test_toolbox.py M test/unit/tools_support.py

Log Message: ----------- Merge pull request #7446 from mvdbeek/fix_concurrent_add_remove

Use a lock on cleanup, expire_tool and cache_tool

Compare: https://github.com/galaxyproject/galaxy/compare/b76d5053fad7...f9df69d5f2d5