1 new commit in galaxy-central: https://bitbucket.org/galaxy/galaxy-central/commits/410a13e7e8dd/ Changeset: 410a13e7e8dd User: jmchilton Date: 2014-02-28 19:42:30 Summary: Add test cases for need_late_validation of select parameters. Two of these fail without JJ's work in pull request 336, additionally these verify 336 doesn't break GATK support for instance. Affected #: 1 file diff -r 3981b0070af02af108ce81091866d531e66b8fd1 -r 410a13e7e8ddabf9a00ffb8ba3bc75d4948447e4 test/unit/tools/test_select_parameters.py --- /dev/null +++ b/test/unit/tools/test_select_parameters.py @@ -0,0 +1,93 @@ +from unittest import TestCase +from galaxy.util import bunch +from galaxy import model +from galaxy.tools.parameters import basic +from elementtree.ElementTree import XML + +import tools_support + + +class SelectToolParameterTestCase( TestCase, tools_support.UsesApp ): + + def test_dep_dummy_datasets_need_late_validation( self ): + self.options_xml = '''<options><filter type="data_meta" ref="input_bam" key="dbkey"/></options>''' + assert self.param.need_late_validation( self.trans, { "input_bam": basic.DummyDataset() } ) + + def test_dep_runtime_values_need_late_validation( self ): + self.options_xml = '''<options><filter type="data_meta" ref="input_bam" key="dbkey"/></options>''' + assert self.param.need_late_validation( self.trans, { "input_bam": basic.RuntimeValue() } ) + + def test_dep_unvalidated_values_need_late_validation( self ): + self.options_xml = '''<options><filter type="data_meta" ref="input_bam" key="dbkey"/></options>''' + assert self.param.need_late_validation( self.trans, { "input_bam": basic.UnvalidatedValue( "42" ) } ) + + def test_dep_real_datasets_no_late_validation( self ): + self.options_xml = '''<options><filter type="data_meta" ref="input_bam" key="dbkey"/></options>''' + assert not self.param.need_late_validation( self.trans, { "input_bam": model.HistoryDatasetAssociation() } ) + + def test_nested_context_validation_needed( self ): + self.options_xml = '''<options><filter type="data_meta" ref="input_bam" key="dbkey"/></options>''' + # Data ref currently must be same level, if not at top level. + assert self.param.need_late_validation( self.trans, { "reference_source": { "my_name": "42", "input_bam": basic.RuntimeValue() } } ) + + def test_nested_context_validation_not_needed( self ): + self.options_xml = '''<options><filter type="data_meta" ref="input_bam" key="dbkey"/></options>''' + # Data ref currently must be same level, if not at top level. + assert not self.param.need_late_validation( self.trans, { "reference_source": { "my_name": "42", "input_bam": model.HistoryDatasetAssociation() } } ) + + # Following test will fail due to bug in Galaxy. + def test_nested_context_validation_needed_in_repeat( self ): + self.type = "data_column" + self.set_ref_text = True + self.options_xml = '''<options><filter type="data_meta" ref="input_bam" key="dbkey"/></options>''' + assert not self.param.need_late_validation( self.trans, { "series": [ { "my_name": "42", "input_bam": model.HistoryDatasetAssociation() } ] } ) + + def test_nested_context_validation_not_needed_in_repeat( self ): + self.type = "data_column" + self.set_ref_text = True + self.options_xml = '''<options><filter type="data_meta" ref="input_bam" key="dbkey"/></options>''' + assert self.param.need_late_validation( self.trans, { "series": [ { "my_name": "42", "input_bam": basic.RuntimeValue() } ] } ) + + # TODO: Good deal of overlap here with DataToolParameterTestCase, + # refactor. + def setUp( self ): + self.setup_app( mock_model=False ) + self.mock_tool = bunch.Bunch( + app=self.app, + tool_type="default", + ) + self.test_history = model.History() + self.app.model.context.add( self.test_history ) + self.app.model.context.flush() + self.trans = bunch.Bunch( + app=self.app, + get_history=lambda: self.test_history, + get_current_user_roles=lambda: [], + workflow_building_mode=False, + webapp=bunch.Bunch( name="galaxy" ), + ) + self.type = "select" + self.set_data_ref = False + self.multiple = False + self.optional = False + self.options_xml = "" + self._param = None + + @property + def param( self ): + if not self._param: + multi_text = "" + if self.multiple: + multi_text = 'multiple="True"' + optional_text = "" + if self.optional: + optional_text = 'optional="True"' + options_text = self.options_xml + data_ref_text = "" + if self.set_data_ref: + data_ref_text = 'data_ref="input_bam"' + template_xml = '''<param name="my_name" type="%s" %s %s %s>%s</param>''' + self.param_xml = XML( template_xml % ( self.type, data_ref_text, multi_text, optional_text, options_text ) ) + self._param = basic.SelectToolParameter( self.mock_tool, self.param_xml ) + + return self._param Repository URL: https://bitbucket.org/galaxy/galaxy-central/ -- This is a commit notification from bitbucket.org. You are receiving this because you have the service enabled, addressing the recipient of this email.