commit/galaxy-central: jmchilton: Better exception handling in job files API.
![](https://secure.gravatar.com/avatar/80f5559d84eded8948e370d0267057c0.jpg?s=120&d=mm&r=g)
1 new commit in galaxy-central: https://bitbucket.org/galaxy/galaxy-central/commits/dffff21295c3/ Changeset: dffff21295c3 User: jmchilton Date: 2014-10-02 16:24:39+00:00 Summary: Better exception handling in job files API. POSTing files to inactive jobs I gues should result in a 403 instead of 400 - it does now - but ItemAccessibilityException and in particular the error message that goes with it doesn't feel quite right. Affected #: 1 file diff -r 6aad6ad39a04c8897198f64af0797397a03d112e -r dffff21295c3ab7ebb9e81a18d4f6639707d49b2 lib/galaxy/webapps/galaxy/api/job_files.py --- a/lib/galaxy/webapps/galaxy/api/job_files.py +++ b/lib/galaxy/webapps/galaxy/api/job_files.py @@ -105,7 +105,7 @@ job = trans.sa_session.query( model.Job ).get( job_id ) if job.finished: error_message = "Attempting to read or modify the files of a job that has already completed." - raise exceptions.MessageException( error_message ) + raise exceptions.ItemAccessibilityException( error_message ) return job def __check_job_can_write_to_path( self, trans, job, path ): Repository URL: https://bitbucket.org/galaxy/galaxy-central/ -- This is a commit notification from bitbucket.org. You are receiving this because you have the service enabled, addressing the recipient of this email.
participants (1)
-
commits-noreply@bitbucket.org