[galaxyproject/galaxy] b5a2fa: do not rule out numbers that are accessed with shi...
Branch: refs/heads/release_18.09 Home: https://github.com/galaxyproject/galaxy Commit: b5a2fafa07fcf1580989d51dd64f335387a568b8 https://github.com/galaxyproject/galaxy/commit/b5a2fafa07fcf1580989d51dd64f3... Author: Martin Cech <marten@bx.psu.edu> Date: 2018-10-01 (Mon, 01 Oct 2018) Changed paths: M client/galaxy/scripts/mvc/ui/ui-slider.js Log Message: ----------- do not rule out numbers that are accessed with shift modifier closes #5370 I think there are more problems with this code: - it assumes too much about the keyboard used and puts unnecessary restrictions on the user - the implementation should be refactored to use KeyboardEvent.key instead of the deprecated charCode Commit: 8ea455303ab76cf94e5c7acdf22d14d75260b188 https://github.com/galaxyproject/galaxy/commit/8ea455303ab76cf94e5c7acdf22d1... Author: Marius van den Beek <m.vandenbeek@gmail.com> Date: 2018-10-04 (Thu, 04 Oct 2018) Changed paths: M client/galaxy/scripts/mvc/ui/ui-slider.js Log Message: ----------- Merge pull request #6810 from martenson/fix-nonUS-keyboards [18.09] do not rule out numbers that are accessed with shift modifier Compare: https://github.com/galaxyproject/galaxy/compare/1c4a4ed8cb60...8ea455303ab7 **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.
participants (1)
-
GitHub