commit/galaxy-central: jmchilton: Fix saving tool state modifications in workflow editor when resource parameters are enabled.
1 new commit in galaxy-central: https://bitbucket.org/galaxy/galaxy-central/commits/9f495158c5ba/ Changeset: 9f495158c5ba Branch: stable User: jmchilton Date: 2014-09-17 15:56:03+00:00 Summary: Fix saving tool state modifications in workflow editor when resource parameters are enabled. Resource parameter selection is only available at runtime in the tool form - not in the workflow editor. It is fairly important that this state not be associated with the workflow since that would cause odd-ness when exporting one workflows to other deployments or as these unversioned resource parameters evolve over time. This fix addresses a consequence of that form not appearing and goes a step further in preventing this state from being associated with worklfow steps. Thanks to Dan for the bug report. Affected #: 1 file diff -r 2855d1a712c45fe45da7585f1ea05ecbb2a6c2fd -r 9f495158c5ba45fcf61fc37d82aa8545eaba0bd5 lib/galaxy/tools/__init__.py --- a/lib/galaxy/tools/__init__.py +++ b/lib/galaxy/tools/__init__.py @@ -2423,6 +2423,14 @@ try: current_case = input.get_current_case( value, trans ) except ValueError, e: + if input.is_job_resource_conditional: + # Unless explicitly given job resource parameters + # (e.g. from the run tool form) don't populate the + # state. Along with other hacks prevents workflow + # saving from populating resource defaults - which + # are meant to be much more transient than the rest + # of tool state. + continue #load default initial value if not test_param_error: test_param_error = str( e ) Repository URL: https://bitbucket.org/galaxy/galaxy-central/ -- This is a commit notification from bitbucket.org. You are receiving this because you have the service enabled, addressing the recipient of this email.
participants (1)
-
commits-noreply@bitbucket.org