[galaxyproject/galaxy] 29cf68: Do not encode a rendered Mako template
Branch: refs/heads/dev Home: https://github.com/galaxyproject/galaxy Commit: 29cf68f0b07d1342fdd1e8f00c1bf751de6b581c https://github.com/galaxyproject/galaxy/commit/29cf68f0b07d1342fdd1e8f00c1bf... Author: Nicola Soranzo <nicola.soranzo@earlham.ac.uk> Date: 2018-07-01 (Sun, 01 Jul 2018) Changed paths: M lib/galaxy/visualization/plugins/plugin.py M lib/galaxy/web/framework/webapp.py M test/unit/unittest_utils/galaxy_mock.py M test/unit/visualizations/plugins/test_VisualizationsRegistry.py Log Message: ----------- Do not encode a rendered Mako template Fix 1 error and 2 failures in unit tests under Python 3, e.g.: ``` FAIL: test_render (unit.visualizations.plugins.test_VisualizationPlugin.VisualizationsPlugin_TestCase) ---------------------------------------------------------------------- Traceback (most recent call last): File "/home/travis/build/galaxyproject/galaxy/test/unit/visualizations/plugins/test_VisualizationPlugin.py", line 180, in test_render self.assertIsInstance(response, string_types) AssertionError: b'\nTrue\n' is not an instance of (<class 'str'>,) ``` Commit: e0721ac8545107bd0eb0194f131bbb687cfcc18f https://github.com/galaxyproject/galaxy/commit/e0721ac8545107bd0eb0194f131bb... Author: Dannon <dannon.baker@gmail.com> Date: 2018-07-01 (Sun, 01 Jul 2018) Changed paths: M lib/galaxy/visualization/plugins/plugin.py M lib/galaxy/web/framework/webapp.py M test/unit/unittest_utils/galaxy_mock.py M test/unit/visualizations/plugins/test_VisualizationsRegistry.py Log Message: ----------- Merge pull request #6431 from nsoranzo/python3 Do not encode a rendered Mako template Compare: https://github.com/galaxyproject/galaxy/compare/af26564559f9...e0721ac85451 **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.
participants (1)
-
GitHub