[galaxyproject/galaxy] 46b4e8: Managers: remove UTC zone when parsing dates
Branch: refs/heads/dev Home: https://github.com/galaxyproject/galaxy Commit: 46b4e8d94cf989f429039a63e38cc739c14e6a76 https://github.com/galaxyproject/galaxy/commit/46b4e8d94cf989f429039a63e38cc... Author: carlfeberhard <carlfeberhard@gmail.com> Date: 2016-03-31 (Thu, 31 Mar 2016) Changed paths: M lib/galaxy/managers/base.py M test/unit/managers/test_HistoryContentsManager.py Log Message: ----------- Managers: remove UTC zone when parsing dates This change creates a more complete regex for parsing dates used in filters. MySQL in particular errored when the UTC zone character 'Z' was appended to a valid iso 8601 date (because it's MySQL). The FilterParser.parse_date method now: - strips both the separator 'T' and any ending 'Z' - one space are allowed as the date/time separator - milliseconds are permitted - both time and time with milliseconds are optional - any added timezone (besides the UTC Z) will cause an error - feedback was made more clear - tests were added (and should make the above more clear) Commit: 1c2b2a5c71d105f0f2d9ac64d7a502f81b4297ec https://github.com/galaxyproject/galaxy/commit/1c2b2a5c71d105f0f2d9ac64d7a50... Author: Dannon Baker <dannon.baker@gmail.com> Date: 2016-03-31 (Thu, 31 Mar 2016) Changed paths: M lib/galaxy/managers/base.py M test/unit/managers/test_HistoryContentsManager.py Log Message: ----------- Merge pull request #2062 from carlfeberhard/fix.date_filter_parsing Managers: remove UTC zone when parsing dates Compare: https://github.com/galaxyproject/galaxy/compare/5fd5343d07f2...1c2b2a5c71d1
participants (1)
-
GitHub