commit/galaxy-central: 2 new changesets
2 new changesets in galaxy-central: http://bitbucket.org/galaxy/galaxy-central/changeset/f197067c32ef/ changeset: f197067c32ef branches: user: natefoo date: 2011-06-02 22:38:19 summary: Backed out changeset 2f84c42a548a. Unbreaks all checkboxes being checked by default, rebreaks default="true". affected #: 1 file (103 bytes) --- a/lib/galaxy/web/form_builder.py Tue May 24 05:33:07 2011 -0400 +++ b/lib/galaxy/web/form_builder.py Thu Jun 02 16:38:19 2011 -0400 @@ -4,7 +4,7 @@ import logging, sys, os, time from cgi import escape -from galaxy.util import restore_text, relpath, nice_size, string_as_bool +from galaxy.util import restore_text, relpath, nice_size from galaxy.web import url_for log = logging.getLogger(__name__) @@ -112,8 +112,6 @@ # above for clarification. Basically, if value is not True, then it will always be a list with # 2 input fields ( a checkbox and a hidden field ) if the checkbox is checked. If it is not # checked, then value will be only the hidden field. - if isinstance( value, basestring ): - return string_as_bool( value ) return isinstance( value, list ) and len( value ) == 2 def set_checked(self, value): if isinstance( value, basestring ): http://bitbucket.org/galaxy/galaxy-central/changeset/7b1c74229393/ changeset: 7b1c74229393 branches: user: natefoo date: 2011-06-02 22:38:34 summary: merge backout affected #: 1 file (103 bytes) --- a/lib/galaxy/web/form_builder.py Thu Jun 02 16:24:43 2011 -0400 +++ b/lib/galaxy/web/form_builder.py Thu Jun 02 16:38:34 2011 -0400 @@ -4,7 +4,7 @@ import logging, sys, os, time from cgi import escape -from galaxy.util import restore_text, relpath, nice_size, string_as_bool +from galaxy.util import restore_text, relpath, nice_size from galaxy.web import url_for log = logging.getLogger(__name__) @@ -112,8 +112,6 @@ # above for clarification. Basically, if value is not True, then it will always be a list with # 2 input fields ( a checkbox and a hidden field ) if the checkbox is checked. If it is not # checked, then value will be only the hidden field. - if isinstance( value, basestring ): - return string_as_bool( value ) return isinstance( value, list ) and len( value ) == 2 def set_checked(self, value): if isinstance( value, basestring ): Repository URL: https://bitbucket.org/galaxy/galaxy-central/ -- This is a commit notification from bitbucket.org. You are receiving this because you have the service enabled, addressing the recipient of this email.
participants (1)
-
Bitbucket