commit/galaxy-central: jmchilton: Re-fix tool API for uploads coming through nginx.
1 new commit in galaxy-central: https://bitbucket.org/galaxy/galaxy-central/commits/facb9f9d2ee4/ Changeset: facb9f9d2ee4 User: jmchilton Date: 2013-11-19 04:26:29 Summary: Re-fix tool API for uploads coming through nginx. Give tools.get_incoming_value a chance to mangle all keys and see if they appear in some other format. Thanks to @natefoo for detecting the problem, determining the source of the error, and describing the exact path through the code - i.e. doing all the work. Affected #: 1 file diff -r b0535b4864b4bf542e31af7acc027fcbb5a00a54 -r facb9f9d2ee4d614d21e4fc1a4a6d99f2668349a lib/galaxy/tools/__init__.py --- a/lib/galaxy/tools/__init__.py +++ b/lib/galaxy/tools/__init__.py @@ -2083,19 +2083,11 @@ if any_group_errors: errors[input.name] = group_errors else: - if key not in incoming \ - and "__force_update__" + key not in incoming: - # No new value provided, and we are only updating, so keep - # the old value (which should already be in the state) and - # preserve the old error message. - pass - else: - incoming_value = get_incoming_value( incoming, key, None ) - value, error = check_param( trans, input, incoming_value, context, source=source ) - # If a callback was provided, allow it to process the value - if error: - errors[ input.name ] = error - state[ input.name ] = value + incoming_value = get_incoming_value( incoming, key, None ) + value, error = check_param( trans, input, incoming_value, context, source=source ) + if error: + errors[ input.name ] = error + state[ input.name ] = value return errors def update_state( self, trans, inputs, state, incoming, source='html', prefix="", context=None, Repository URL: https://bitbucket.org/galaxy/galaxy-central/ -- This is a commit notification from bitbucket.org. You are receiving this because you have the service enabled, addressing the recipient of this email.
participants (1)
-
commits-noreply@bitbucket.org