1 new commit in galaxy-central: https://bitbucket.org/galaxy/galaxy-central/commits/820ff73e8aab/ Changeset: 820ff73e8aab User: greg Date: 2013-11-29 22:28:25 Summary: Attempt to display the results of the tool shed's install and test framework test run even if the preparation script was not executed before the test run. Affected #: 1 file diff -r 8544d14f89dd48d313384a22117f56fa07a99974 -r 820ff73e8aab805b7f4f4f50cb66d0f47adc5bc2 lib/tool_shed/util/container_util.py --- a/lib/tool_shed/util/container_util.py +++ b/lib/tool_shed/util/container_util.py @@ -1062,37 +1062,41 @@ tool_test_results_root_folder.folders.append( test_runs_folder ) for index, tool_test_results_dict in enumerate( tool_test_results_dicts ): test_environment_dict = tool_test_results_dict.get( 'test_environment', None ) - if test_environment_dict is not None: - time_tested = test_environment_dict.get( 'time_tested', 'unknown_%d' % index ) - if multiple_tool_test_results_dicts: - folder_id += 1 - containing_folder = Folder( id=folder_id, key='test_results', label=time_tested, parent=test_runs_folder ) - test_runs_folder.folders.append( containing_folder ) - else: - containing_folder = tool_test_results_root_folder - test_results_dict_id += 1 + if test_environment_dict is None: + # the test environment entry will exist only if the preparation script check_re;ositories_for_functional_tests.py + # was executed prior to the ~/install_and_test_repositories/functional_tests.py script. If that did not occur, + # we'll display test result, but the test_environment entries will not be complete. + test_environment_dict = {} + time_tested = test_environment_dict.get( 'time_tested', 'unknown_%d' % index ) + if multiple_tool_test_results_dicts: folder_id += 1 - folder = Folder( id=folder_id, key='test_environment', label='Automated test environment', parent=containing_folder ) - containing_folder.folders.append( folder ) - architecture = test_environment_dict.get( 'architecture', '' ) - galaxy_database_version = test_environment_dict.get( 'galaxy_database_version', '' ) - galaxy_revision = test_environment_dict.get( 'galaxy_revision', '' ) - python_version = test_environment_dict.get( 'python_version', '' ) - system = test_environment_dict.get( 'system', '' ) - tool_shed_database_version = test_environment_dict.get( 'tool_shed_database_version', '' ) - tool_shed_mercurial_version = test_environment_dict.get( 'tool_shed_mercurial_version', '' ) - tool_shed_revision = test_environment_dict.get( 'tool_shed_revision', '' ) - test_environment = TestEnvironment( id=1, - architecture=architecture, - galaxy_database_version=galaxy_database_version, - galaxy_revision=galaxy_revision, - python_version=python_version, - system=system, - time_tested=time_tested, - tool_shed_database_version=tool_shed_database_version, - tool_shed_mercurial_version=tool_shed_mercurial_version, - tool_shed_revision=tool_shed_revision ) - folder.test_environments.append( test_environment ) + containing_folder = Folder( id=folder_id, key='test_results', label=time_tested, parent=test_runs_folder ) + test_runs_folder.folders.append( containing_folder ) + else: + containing_folder = tool_test_results_root_folder + test_results_dict_id += 1 + folder_id += 1 + folder = Folder( id=folder_id, key='test_environment', label='Automated test environment', parent=containing_folder ) + containing_folder.folders.append( folder ) + architecture = test_environment_dict.get( 'architecture', '' ) + galaxy_database_version = test_environment_dict.get( 'galaxy_database_version', '' ) + galaxy_revision = test_environment_dict.get( 'galaxy_revision', '' ) + python_version = test_environment_dict.get( 'python_version', '' ) + system = test_environment_dict.get( 'system', '' ) + tool_shed_database_version = test_environment_dict.get( 'tool_shed_database_version', '' ) + tool_shed_mercurial_version = test_environment_dict.get( 'tool_shed_mercurial_version', '' ) + tool_shed_revision = test_environment_dict.get( 'tool_shed_revision', '' ) + test_environment = TestEnvironment( id=1, + architecture=architecture, + galaxy_database_version=galaxy_database_version, + galaxy_revision=galaxy_revision, + python_version=python_version, + system=system, + time_tested=time_tested, + tool_shed_database_version=tool_shed_database_version, + tool_shed_mercurial_version=tool_shed_mercurial_version, + tool_shed_revision=tool_shed_revision ) + folder.test_environments.append( test_environment ) not_tested_dict = tool_test_results_dict.get( 'not_tested', {} ) if not_tested_dict: folder_id += 1 Repository URL: https://bitbucket.org/galaxy/galaxy-central/ -- This is a commit notification from bitbucket.org. You are receiving this because you have the service enabled, addressing the recipient of this email.