[galaxyproject/galaxy] 54aecb: Properly deal with missing tools in subworkflows
Branch: refs/heads/release_18.09 Home: https://github.com/galaxyproject/galaxy Commit: 54aecb3f31812c86d370034cf557537780efbcdf https://github.com/galaxyproject/galaxy/commit/54aecb3f31812c86d370034cf5575... Author: mvdbeek <m.vandenbeek@gmail.com> Date: 2019-01-17 (Thu, 17 Jan 2019) Changed paths: M client/galaxy/scripts/mvc/workflow/workflow-manager.js M lib/galaxy/exceptions/__init__.py M lib/galaxy/managers/workflows.py M lib/galaxy/workflow/modules.py Log Message: ----------- Properly deal with missing tools in subworkflows If a subworkflow is missing tools the entire parent workflow couldn't be loaded into the editor, because we raised an exception. This is now only logged as an error. On the user side we now prevent running and saving such workflows by actually implementing the `get_errors` method for the SubWorkflowModule class. This should fix https://github.com/galaxyproject/galaxy/issues/7140. Commit: b1b1d848d35816cfa344aeb687c78c7a0c93e66f https://github.com/galaxyproject/galaxy/commit/b1b1d848d35816cfa344aeb687c78... Author: mvdbeek <m.vandenbeek@gmail.com> Date: 2019-01-17 (Thu, 17 Jan 2019) Changed paths: M lib/galaxy/workflow/modules.py Log Message: ----------- Fix loading subworkflows Commit: 6f861dec7e897bbc06b2cffbb33b2fdd9e6ac11a https://github.com/galaxyproject/galaxy/commit/6f861dec7e897bbc06b2cffbb33b2... Author: mvdbeek <m.vandenbeek@gmail.com> Date: 2019-01-18 (Fri, 18 Jan 2019) Changed paths: M lib/galaxy/exceptions/__init__.py Log Message: ----------- Overridde __init__ for ToolMissingException Commit: 889c1026c0893636b4fc6375443408c0ec2b4a8a https://github.com/galaxyproject/galaxy/commit/889c1026c0893636b4fc637544340... Author: John Chilton <jmchilton@gmail.com> Date: 2019-01-18 (Fri, 18 Jan 2019) Changed paths: M client/galaxy/scripts/mvc/workflow/workflow-manager.js M lib/galaxy/exceptions/__init__.py M lib/galaxy/managers/workflows.py M lib/galaxy/workflow/modules.py Log Message: ----------- Merge pull request #7227 from mvdbeek/fix_workflow_loading_saving [18.09] Properly deal with missing tools in workflows Compare: https://github.com/galaxyproject/galaxy/compare/105a1d8a61ef...889c1026c089 **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.
participants (1)
-
GitHub