Branch: refs/heads/release_16.01 Home: https://github.com/galaxyproject/galaxy Commit: eca2c3bcee2c9f05dee062c60607251a589a93fd https://github.com/galaxyproject/galaxy/commit/eca2c3bcee2c9f05dee062c606072... Author: John Chilton <jmchilton@gmail.com> Date: 2016-01-19 (Tue, 19 Jan 2016) Changed paths: M test/api/test_workflows.py A test/functional/tools/for_workflows/1.bam A test/functional/tools/for_workflows/mapper.xml A test/functional/tools/for_workflows/pileup.xml M test/functional/tools/samples_tool_conf.xml Log Message: ----------- Failing test case to exhibit #1514. Commit: f1394d250db103eda0bc88044eaa92f54f56476c https://github.com/galaxyproject/galaxy/commit/f1394d250db103eda0bc88044eaa9... Author: John Chilton <jmchilton@gmail.com> Date: 2016-01-19 (Tue, 19 Jan 2016) Changed paths: M lib/galaxy/tools/parameters/basic.py M lib/galaxy/tools/parameters/validation.py Log Message: ----------- Fix #1514. Prior to PR #1302 workflows wouldn't validate call validate at all on inputs. 1302 was perhaps an over correction that causes validate to be called on datasets that aren't yet READY but require metadata. This rolls that back somewhat, other parameters will still validate - but validation asserting the existence of metadata won't get called in workflows. This is still not ideal but after 1302 and this - we are still in a better, more secure place than beforehand. One might argue that since we need to introduce a new validation point (right before a job is scheduled and set to QUEUED) - that we would be better off rolling back #1302 entirely. I've considered that, but I still think it is better to fail fast on the other problems, also I would rather call the validation code too many times than not enough and it would be very late in the release cycle for such a change. Commit: 17abd4a30d41ff070202c1818ad84c015a642733 https://github.com/galaxyproject/galaxy/commit/17abd4a30d41ff070202c1818ad84... Author: Aysam Guerler <aysam.guerler@gmail.com> Date: 2016-01-21 (Thu, 21 Jan 2016) Changed paths: M lib/galaxy/tools/parameters/basic.py M lib/galaxy/tools/parameters/validation.py M test/api/test_workflows.py A test/functional/tools/for_workflows/1.bam A test/functional/tools/for_workflows/mapper.xml A test/functional/tools/for_workflows/pileup.xml M test/functional/tools/samples_tool_conf.xml Log Message: ----------- Merge pull request #1536 from jmchilton/issue_1514 [16.01] Test case and fix for issue #1514 Compare: https://github.com/galaxyproject/galaxy/compare/a00faba4fefa...17abd4a30d41