commit/galaxy-central: smcmanus: Fixed bug in accessing /folders content as non-admin. Added comment.
1 new commit in galaxy-central: https://bitbucket.org/galaxy/galaxy-central/changeset/f265985eaca2/ changeset: f265985eaca2 user: smcmanus date: 2012-10-23 00:06:09 summary: Fixed bug in accessing /folders content as non-admin. Added comment. affected #: 2 files diff -r 97816731e24bff2d825c7713787df2b0f2fc445f -r f265985eaca2a5fad402810c2cf030ec26f89e97 lib/galaxy/webapps/galaxy/api/folder_contents.py --- a/lib/galaxy/webapps/galaxy/api/folder_contents.py +++ b/lib/galaxy/webapps/galaxy/api/folder_contents.py @@ -59,7 +59,7 @@ # TODO: Find the API's path to this folder if necessary. # This was needed in recursive descent, but it's not needed # for "ls"-style content checking: - if not folder or not ( trans.user_is_admin() or trans.app.security_agent.can_access_library_item( current_user_roles, folder ) ): + if not folder or not ( trans.user_is_admin() or trans.app.security_agent.can_access_library_item( current_user_roles, folder, trans.user ) ): trans.response.status = 400 return "Invalid folder id ( %s ) specified." % str( folder_id ) diff -r 97816731e24bff2d825c7713787df2b0f2fc445f -r f265985eaca2a5fad402810c2cf030ec26f89e97 lib/galaxy/webapps/galaxy/api/folders.py --- a/lib/galaxy/webapps/galaxy/api/folders.py +++ b/lib/galaxy/webapps/galaxy/api/folders.py @@ -50,7 +50,6 @@ moved here. o payload's relevant params: - - create_type: "file" or "folder" (required) - folder_id: This is the parent folder's id (required) """ log.debug( "FoldersController.create: enter" ) Repository URL: https://bitbucket.org/galaxy/galaxy-central/ -- This is a commit notification from bitbucket.org. You are receiving this because you have the service enabled, addressing the recipient of this email.
participants (1)
-
Bitbucket