commit/galaxy-central: jgoecks: Fix filtering of deleted objects in grid framework when using sqlite. Also make history grid's label for deleted filter clearer. Fixes #596
1 new changeset in galaxy-central: http://bitbucket.org/galaxy/galaxy-central/changeset/c176363cb7b2/ changeset: c176363cb7b2 user: jgoecks date: 2011-07-21 16:04:48 summary: Fix filtering of deleted objects in grid framework when using sqlite. Also make history grid's label for deleted filter clearer. Fixes #596 affected #: 2 files (15 bytes) --- a/lib/galaxy/web/controllers/history.py Thu Jul 21 09:43:49 2011 -0400 +++ b/lib/galaxy/web/controllers/history.py Thu Jul 21 10:04:48 2011 -0400 @@ -56,7 +56,7 @@ grids.GridColumn( "Created", key="create_time", format=time_ago ), grids.GridColumn( "Last Updated", key="update_time", format=time_ago ), # Columns that are valid for filtering but are not visible. - grids.DeletedColumn( "Deleted", key="deleted", visible=False, filterable="advanced" ) + grids.DeletedColumn( "Status", key="deleted", visible=False, filterable="advanced" ) ] columns.append( grids.MulticolFilterColumn( --- a/lib/galaxy/web/framework/helpers/grids.py Thu Jul 21 09:43:49 2011 -0400 +++ b/lib/galaxy/web/framework/helpers/grids.py Thu Jul 21 10:04:48 2011 -0400 @@ -631,7 +631,7 @@ if column_filter == "All": pass elif column_filter in [ "True", "False" ]: - query = query.filter( self.model_class.deleted == column_filter ) + query = query.filter( self.model_class.deleted == ( column_filter == "True" ) ) return query class StateColumn( GridColumn ): Repository URL: https://bitbucket.org/galaxy/galaxy-central/ -- This is a commit notification from bitbucket.org. You are receiving this because you have the service enabled, addressing the recipient of this email.
participants (1)
-
Bitbucket