commit/galaxy-central: dannon: Workflow editor fix for the case where RenameActions had null action arguments vs being unspecified or {} as expected. This situation exists in very few rename actions and hasn't been reproduced, may be legacy workflow steps.

24 Apr 2012

1 new commit in galaxy-central:


https://bitbucket.org/galaxy/galaxy-central/changeset/ce32134aec56/
changeset:   ce32134aec56
user:        dannon
date:        2012-04-24 17:53:35
summary:     Workflow editor fix for the case where RenameActions had null action arguments vs being unspecified or {} as expected.  This situation exists in very few rename actions and hasn't been reproduced, may be legacy workflow steps.
affected #:  1 file

diff -r ea722ae95cb7c99742c081bcd17bddc441dfa2fb -r ce32134aec5687e9ee5386a7742ab97b950f2a5e lib/galaxy/jobs/actions/post.py

--- a/lib/galaxy/jobs/actions/post.py
+++ b/lib/galaxy/jobs/actions/post.py
@@ -203,11 +203,10 @@
     @classmethod
     def get_config_form(cls, trans):
         form = """
-            if ((pja.action_arguments !== undefined) && (pja.action_arguments.newname !== undefined)){
+            if (pja.action_arguments && pja.action_arguments.newname){
                 p_str += "<label for='pja__"+pja.output_name+"__RenameDatasetAction__newname'>New output name:</label>\
                           <input type='text' name='pja__"+pja.output_name+"__RenameDatasetAction__newname' value=\\"" + pja.action_arguments.newname.replace(/"/g, """) + "\\"/>";
             }
-            
             else{
                 p_str += "<label for='pja__"+pja.output_name+"__RenameDatasetAction__newname'>New output name:</label>\
                           <input type='text' name='pja__"+pja.output_name+"__RenameDatasetAction__newname' value=''/>";

Repository URL: https://bitbucket.org/galaxy/galaxy-central/

--

This is a commit notification from bitbucket.org. You are receiving
this because you have the service enabled, addressing the recipient of
this email.

    

Bitbucket

tags

participants (1)