1 new commit in galaxy-central: https://bitbucket.org/galaxy/galaxy-central/commits/c43a73f270ad/ Changeset: c43a73f270ad User: carlfeberhard Date: 2013-05-17 22:30:50 Summary: Bugfix: remove DEFAULT_ORDER_BY in visualizations mixin. Affected #: 1 file diff -r ae31fdf708efc84f1db7176b170596c9eb7f0212 -r c43a73f270ad0bc5d3cf397cac83e0d805f4dfa1 lib/galaxy/web/base/controller.py --- a/lib/galaxy/web/base/controller.py +++ b/lib/galaxy/web/base/controller.py @@ -689,7 +689,6 @@ Mixin for controllers that use Visualization objects. """ - DEFAULT_ORDER_BY = [ model.Visualization.title ] viz_types = [ "trackster" ] def get_visualization( self, trans, id, check_ownership=True, check_accessible=False ): @@ -715,8 +714,10 @@ Set `query_only` to return just the query for further filtering or processing. """ + #TODO: move into model (as class attr) + DEFAULT_ORDER_BY = [ model.Visualization.title ] if not order_by: - order_by = self.DEFAULT_ORDER_BY + order_by = DEFAULT_ORDER_BY if not isinstance( order_by, list ): order_by = [ order_by ] query = trans.sa_session.query( model.Visualization ) @@ -736,8 +737,9 @@ Set `query_only` to return just the query for further filtering or processing. """ + DEFAULT_ORDER_BY = [ model.Visualization.title ] if not order_by: - order_by = self.DEFAULT_ORDER_BY + order_by = DEFAULT_ORDER_BY if not isinstance( order_by, list ): order_by = [ order_by ] query = trans.sa_session.query( model.Visualization ).join( model.VisualizationUserShareAssociation ) @@ -760,8 +762,9 @@ Set `query_only` to return just the query for further filtering or processing. """ + DEFAULT_ORDER_BY = [ model.Visualization.title ] if not order_by: - order_by = self.DEFAULT_ORDER_BY + order_by = DEFAULT_ORDER_BY if not isinstance( order_by, list ): order_by = [ order_by ] query = trans.sa_session.query( model.Visualization ) Repository URL: https://bitbucket.org/galaxy/galaxy-central/ -- This is a commit notification from bitbucket.org. You are receiving this because you have the service enabled, addressing the recipient of this email.