commit/galaxy-central: greg: Fix for managing tool shed repository reviews.
1 new commit in galaxy-central: https://bitbucket.org/galaxy/galaxy-central/changeset/5ae989999225/ changeset: 5ae989999225 user: greg date: 2012-10-23 20:38:38 summary: Fix for managing tool shed repository reviews. affected #: 1 file diff -r 1d8578333bd37d7fd84f276d115f414bbde0b607 -r 5ae989999225b9edf884de6dfe23a2e82f9de403 lib/galaxy/webapps/community/controllers/repository_review.py --- a/lib/galaxy/webapps/community/controllers/repository_review.py +++ b/lib/galaxy/webapps/community/controllers/repository_review.py @@ -654,7 +654,7 @@ repo_dir = repository.repo_path repo = hg.repository( get_configured_ui(), repo_dir ) metadata_revision_hashes = [ metadata_revision.changeset_revision for metadata_revision in repository.metadata_revisions ] - reviewed_revision_hashes = [ reviewed_revisions.changeset_revision for reviewed_revisions in repository.reviewed_revisions ] + reviewed_revision_hashes = [ review.changeset_revision for review in repository.reviews ] reviews_dict = odict() for changeset in get_reversed_changelog_changesets( repo ): ctx = repo.changectx( changeset ) @@ -667,7 +667,10 @@ # Determine if the current user can add a review to this revision. can_add_review = trans.user not in [ repository_review.user for repository_review in repository_reviews ] repository_metadata = get_repository_metadata_by_changeset_revision( trans, repository_id, changeset_revision ) - repository_metadata_reviews = util.listify( repository_metadata.reviews ) + if repository_metadata: + repository_metadata_reviews = util.listify( repository_metadata.reviews ) + else: + repository_metadata_reviews = [] else: repository_reviews = [] repository_metadata_reviews = [] Repository URL: https://bitbucket.org/galaxy/galaxy-central/ -- This is a commit notification from bitbucket.org. You are receiving this because you have the service enabled, addressing the recipient of this email.
participants (1)
-
Bitbucket