commit/galaxy-central: dan: Enhance Tool.check_and_update_param_values_helper() to check that the type of value provided is valid for the input parameter currently declared. Fixes issue where a server error would occur within workflows when parameter's type has changed to a non-compatible one: e.g. conditional group changed to dataset input.
1 new commit in galaxy-central: https://bitbucket.org/galaxy/galaxy-central/commits/eb4dac39eed5/ changeset: eb4dac39eed5 user: dan date: 2013-01-07 17:07:52 summary: Enhance Tool.check_and_update_param_values_helper() to check that the type of value provided is valid for the input parameter currently declared. Fixes issue where a server error would occur within workflows when parameter's type has changed to a non-compatible one: e.g. conditional group changed to dataset input. affected #: 1 file diff -r f93f509ca0c2a21acdf0ed17615d1caf839dcb98 -r eb4dac39eed53cc0ef1550ee63486358fd53ad59 lib/galaxy/tools/__init__.py --- a/lib/galaxy/tools/__init__.py +++ b/lib/galaxy/tools/__init__.py @@ -2181,7 +2181,12 @@ self.check_and_update_param_values_helper( input.cases[current].inputs, group_values, trans, messages, context, prefix ) else: # Regular tool parameter, no recursion needed - pass + try: + #this will fail when a parameter's type has changed to a non-compatible one: e.g. conditional group changed to dataset input + input.value_from_basic( values[ input.name ], trans.app, ignore_errors=False ) + except: + messages[ input.name ] = "Value no longer valid for '%s%s', replaced with default" % ( prefix, input.label ) + values[ input.name ] = input.get_initial_value( trans, context ) def handle_unvalidated_param_values( self, input_values, app ): """ Find any instances of `UnvalidatedValue` within input_values and Repository URL: https://bitbucket.org/galaxy/galaxy-central/ -- This is a commit notification from bitbucket.org. You are receiving this because you have the service enabled, addressing the recipient of this email.
participants (1)
-
Bitbucket