[galaxyproject/galaxy] cd3f28: Unicodify has different semantics to str
Branch: refs/heads/dev Home: https://github.com/galaxyproject/galaxy Commit: cd3f28d8a731475158bb97b807cb451929307cd0 https://github.com/galaxyproject/galaxy/commit/cd3f28d8a731475158bb97b807cb4... Author: Eric Rasche <rasche.eric@gmail.com> Date: 2016-05-10 (Tue, 10 May 2016) Changed paths: M lib/galaxy/tools/errors.py Log Message: ----------- Unicodify has different semantics to str Originally my patch was written with str()'s behaviour in mind. If a value is None, it gets cast. I did not test my patch well enough following @nsoranzo's request to replace with unicodify(). In that case a raw None gets passed to cgi.escape() causing a bug Commit: 75a99eb112355047692a3a97274f552eab58e705 https://github.com/galaxyproject/galaxy/commit/75a99eb112355047692a3a97274f5... Author: Dannon Baker <dannon.baker@gmail.com> Date: 2016-05-10 (Tue, 10 May 2016) Changed paths: M lib/galaxy/tools/errors.py Log Message: ----------- Merge pull request #2336 from erasche/fix-for-the-nth-bloody-time Unicodify has different semantics to str, causing bug reporter bug Compare: https://github.com/galaxyproject/galaxy/compare/3ac9d2aa0aa2...75a99eb11235
participants (1)
-
GitHub