Branch: refs/heads/release_18.05 Home: https://github.com/galaxyproject/galaxy Commit: 3683639be9b0b8402a33404a4c92bb3e77946052 https://github.com/galaxyproject/galaxy/commit/3683639be9b0b8402a33404a4c92b... Author: mvdbeek <m.vandenbeek@gmail.com> Date: 2018-05-25 (Fri, 25 May 2018) Changed paths: M lib/galaxy/tools/parameters/basic.py Log Message: ----------- Revert "Refactor code for clarity" This reverts commit 91e97b60968d6813bd7a28d0d60e778b288ac385. The commit to revert causes https://github.com/galaxyproject/galaxy/issues/6219, where the `optional="True"` flag is not repected anymore. This is because we raise an exception before checking that `value` may be legitimately `None`. Commit: 9df63093664cda98890f2cfafe716f63a735d39f https://github.com/galaxyproject/galaxy/commit/9df63093664cda98890f2cfafe716... Author: mvdbeek <m.vandenbeek@gmail.com> Date: 2018-05-25 (Fri, 25 May 2018) Changed paths: M lib/galaxy/tools/parameters/basic.py Log Message: ----------- Fix optional input in DrillDownSelectToolParameter.from_json() as well Thanks for catching that @nsoranzo Commit: ec45c970c57af9d2237f6d5e3e6c30f0cbbfce20 https://github.com/galaxyproject/galaxy/commit/ec45c970c57af9d2237f6d5e3e6c3... Author: Nicola Soranzo <nicola.soranzo@earlham.ac.uk> Date: 2018-05-25 (Fri, 25 May 2018) Changed paths: A test/functional/tools/empty_select.xml Log Message: ----------- Add test tool for empty optional select To easily reproduce https://github.com/galaxyproject/galaxy/issues/6219 . Commit: e91f91b5f217c90e937b2608b91a9672300960c7 https://github.com/galaxyproject/galaxy/commit/e91f91b5f217c90e937b2608b91a9... Author: Dannon <dannon.baker@gmail.com> Date: 2018-05-25 (Fri, 25 May 2018) Changed paths: M lib/galaxy/tools/parameters/basic.py A test/functional/tools/empty_select.xml Log Message: ----------- Merge pull request #6222 from mvdbeek/fix_optional_input [18.05] Fix optional="True" inputs Compare: https://github.com/galaxyproject/galaxy/compare/8b37b5ad871b...e91f91b5f217 **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.