[galaxyproject/galaxy] b7be41: Re-allow workflow outputs that aren't produced dur...
Branch: refs/heads/dev Home: https://github.com/galaxyproject/galaxy Commit: b7be4162bd2f5ea43b318dc7ea3f552b6475d9a2 https://github.com/galaxyproject/galaxy/commit/b7be4162bd2f5ea43b318dc7ea3f5... Author: John Chilton <jmchilton@gmail.com> Date: 2017-12-06 (Wed, 06 Dec 2017) Changed paths: M lib/galaxy/workflow/run.py M test/api/test_workflows.py Log Message: ----------- Re-allow workflow outputs that aren't produced during workflow scheduling. These are sort of an error in the workflow definition but we don't have a means to competently display this information to the user via the UI so I think we need to just allow this to happen. I've attached a test case that exhibits this behavior and passes under 17.09 but fails under the current dev branch without these fixes. This was broken in https://github.com/galaxyproject/galaxy/commit/d5f98f49045bca351e982f17cac93... when we started to actually persist pointers to workflow invocation outputs (as part of https://github.com/galaxyproject/galaxy/pull/5013). Commit: 4925660ab4aa2974c6ac8e94180180bac7db9781 https://github.com/galaxyproject/galaxy/commit/4925660ab4aa2974c6ac8e9418018... Author: John Chilton <jmchilton@gmail.com> Date: 2017-12-06 (Wed, 06 Dec 2017) Changed paths: M test/api/test_workflows.py Log Message: ----------- Revert extra assertions that are causing unrelated issues to surface. The unrelated issues are serious problems though and I've created an issue to track them https://github.com/galaxyproject/galaxy/issues/5146. Commit: c8d45dd4b37c707d8ebe1d104c8a3e72d016bb9d https://github.com/galaxyproject/galaxy/commit/c8d45dd4b37c707d8ebe1d104c8a3... Author: Björn Grüning <bjoern@gruenings.eu> Date: 2017-12-07 (Thu, 07 Dec 2017) Changed paths: M lib/galaxy/workflow/run.py M test/api/test_workflows.py Log Message: ----------- Merge pull request #5143 from jmchilton/fix_missing_outputs Re-allow workflow outputs that aren't produced during workflow scheduling. Compare: https://github.com/galaxyproject/galaxy/compare/c8937c8929a5...c8d45dd4b37c
participants (1)
-
GitHub