Branch: refs/heads/dev Home: https://github.com/galaxyproject/galaxy Commit: 87bb576c39dadadbf119167dee581a6801a54cea https://github.com/galaxyproject/galaxy/commit/87bb576c39dadadbf119167dee581... Author: John Chilton <jmchilton@gmail.com> Date: 2017-09-19 (Tue, 19 Sep 2017) Changed paths: M test/selenium_tests/framework.py M test/selenium_tests/test_custom_builds.py M test/selenium_tests/test_published_histories_grid.py M test/selenium_tests/test_saved_histories.py Log Message: ----------- Improved state handling for @anatskiy-style Selenium tests. These tests aren't idealized unittest.TestCase because they initialize class level data in instance level methods. While this isn't ideal, it is seems an entirely fair workaround given that SeleniumTestCase setups up the Selenium connection itself in an instance method - so class-level initializers would not be able to setup Galaxy data. Since I think we will continue using this pattern then, probably best to formalize it a bit and improve error handling. This provides a formal super class for these test cases that provides a uniform method for setting up the class level data and tracks whether this is successful or not. This serves a couple purposes beyond simple uniformity. First, it tracks if the state has actually been setup or not and will skip subsequent tests if it hasn't. Some of these tests aren't passing very consistently on Jenkins and so we get a bunch of extra noise for tests that are attempting to run without their preconditions met - this will fix that and make the original errors much more clear. Moving the "hacky" part of this into the framework itself also means the tests themselves don't have to repeat hacks like seeing if variables are set with ``getattr`` and such - I always prefer one framework hack to a dozen application hacks. Commit: 3f51e7dc1ef99a68aa8694cfe6858a70e9482e50 https://github.com/galaxyproject/galaxy/commit/3f51e7dc1ef99a68aa8694cfe6858... Author: Martin Cech <marten@bx.psu.edu> Date: 2017-09-19 (Tue, 19 Sep 2017) Changed paths: M test/selenium_tests/framework.py M test/selenium_tests/test_custom_builds.py M test/selenium_tests/test_published_histories_grid.py M test/selenium_tests/test_saved_histories.py Log Message: ----------- Merge pull request #4647 from jmchilton/selenium_fixes_28 Improved state handling for @anatskiy-style Selenium tests. Compare: https://github.com/galaxyproject/galaxy/compare/844f083c7b8c...3f51e7dc1ef9