Branch: refs/heads/dev Home: https://github.com/galaxyproject/galaxy Commit: 1e832733db6c6d3e7e191886d836f05708a84440 https://github.com/galaxyproject/galaxy/commit/1e832733db6c6d3e7e191886d836f... Author: John Chilton <jmchilton@gmail.com> Date: 2017-09-10 (Sun, 10 Sep 2017) Changed paths: M test/galaxy_selenium/navigates_galaxy.py Log Message: ----------- Improve error reporting in Selenium tests when ``wait_for_logged_in`` fails. Previously just a notification about waiting for ``a.loggedin-only`` failed would show up. This doesn't indicate if the login failed completely or the masthead just failed to update. I suspect the login failed completely, but just in case I've updated the error handling to actually ping the API and check and print a better error message with this information. New messages look like: ``` TimeoutException: Message: Failed waiting for masthead to update for login, but user API response indicates [test0ol61vs8fo] is logged in. This seems to be a bug in Galaxy. API response was [{u'username': u'test0ol61vs8fo', u'quota_percent': None, u'preferences': {}, u'total_disk_usage': 0.0, u'deleted': False, u'id': u'adb5f5c93f827949', u'nice_total_disk_usage': u'0 bytes', u'quota': None, u'email': u'test0ol61vs8fo@test.test', u'is_admin': False, u'tags_used': [], u'purged': False}].Timeout waiting on CSS selector [a.loggedin-only-x] to become visible. ``` and ``` TimeoutException: Message: Failed waiting for masthead to update for login, API indicates no user is logged in - there is a problem with this test. API response was [{u'quota_percent': None, u'nice_total_disk_usage': u'0 bytes', u'total_disk_usage': 0}]. Timeout waiting on CSS selector [a.loggedin-only] to become visible. ``` Commit: 1359965a992f3a5f3a33276e6d1e1ea6afca0bd8 https://github.com/galaxyproject/galaxy/commit/1359965a992f3a5f3a33276e6d1e1... Author: Dannon Baker <dannon.baker@gmail.com> Date: 2017-09-11 (Mon, 11 Sep 2017) Changed paths: M test/galaxy_selenium/navigates_galaxy.py Log Message: ----------- Merge pull request #4589 from jmchilton/selenium_fixes_26 Improve error reporting in Selenium tests when ``wait_for_logged_in`` fails. Compare: https://github.com/galaxyproject/galaxy/compare/a21f05d9a8aa...1359965a992f