commit/galaxy-central: dannon: Detail why the 307 redirect tracking attempt in tool_shed/scripts/api/common.py does not work.
1 new commit in galaxy-central: https://bitbucket.org/galaxy/galaxy-central/commits/2006b8020cb2/ Changeset: 2006b8020cb2 User: dannon Date: 2014-06-09 23:02:27 Summary: Detail why the 307 redirect tracking attempt in tool_shed/scripts/api/common.py does not work. Affected #: 1 file diff -r 80968afd0cba850290103fb20edad4c6d3c02899 -r 2006b8020cb2b3908dc186fc02bf0635a232bffb lib/tool_shed/scripts/api/common.py --- a/lib/tool_shed/scripts/api/common.py +++ b/lib/tool_shed/scripts/api/common.py @@ -179,7 +179,10 @@ url = make_url( url, api_key=api_key, args=None ) # Fix for handling 307 redirect not being handled nicely by urllib2.urlopen when the # urllib2.Request has data provided. - url = urllib2.urlopen( urllib2.Request( url ) ).geturl() + # NOTE: This approach does *not* work -- this makes an extra GET request to the + # base collection with the method as the ID. That will never decode + # correctly. + # url = urllib2.urlopen( urllib2.Request( url ) ).geturl() req = urllib2.Request( url, headers = { 'Content-Type': 'application/json' }, data = json.dumps( data ) ) return json.loads( urllib2.urlopen( req ).read() ) Repository URL: https://bitbucket.org/galaxy/galaxy-central/ -- This is a commit notification from bitbucket.org. You are receiving this because you have the service enabled, addressing the recipient of this email.
participants (1)
-
commits-noreply@bitbucket.org