2 new commits in galaxy-central: https://bitbucket.org/galaxy/galaxy-central/commits/e54372d60f11/ Changeset: e54372d60f11 Branch: stable User: jgoecks Date: 2013-11-14 17:00:19 Summary: Trackster: only allow datasets with proper dbkey to be added to visualization. This is a regression because summary data format [bigwig] requires a proper dbkey. Affected #: 1 file diff -r 88a08db3c73393ef4f64b0c2f50262d5aa03967b -r e54372d60f111f4be26868ba416649697b551a13 lib/galaxy/webapps/galaxy/controllers/visualization.py --- a/lib/galaxy/webapps/galaxy/controllers/visualization.py +++ b/lib/galaxy/webapps/galaxy/controllers/visualization.py @@ -86,15 +86,19 @@ class DbKeyColumn( grids.GridColumn ): """ Column for filtering by and displaying dataset dbkey. """ def filter( self, trans, user, query, dbkey ): - """ Filter by dbkey; datasets without a dbkey are returned as well. """ - # use raw SQL b/c metadata is a BLOB + """ Filter by dbkey. """ + # Use raw SQL b/c metadata is a BLOB. dbkey_user, dbkey = decode_dbkey( dbkey ) dbkey = dbkey.replace("'", "\\'") - return query.filter( or_( \ - or_( "metadata like '%%\"dbkey\": [\"%s\"]%%'" % dbkey, "metadata like '%%\"dbkey\": \"%s\"%%'" % dbkey ), \ - or_( "metadata like '%%\"dbkey\": [\"?\"]%%'", "metadata like '%%\"dbkey\": \"?\"%%'" ) \ - ) - ) + return query.filter( or_( "metadata like '%%\"dbkey\": [\"%s\"]%%'" % dbkey, "metadata like '%%\"dbkey\": \"%s\"%%'" % dbkey ) ) + + #Use this query when datasets with matching dbkey *or* no dbkey can be added to the visualization. + #return query.filter( or_( \ + # or_( "metadata like '%%\"dbkey\": [\"%s\"]%%'" % dbkey, "metadata like '%%\"dbkey\": \"%s\"%%'" % dbkey ), \ + # or_( "metadata like '%%\"dbkey\": [\"?\"]%%'", "metadata like '%%\"dbkey\": \"?\"%%'" ) \ + # ) + # ) + class HistoryColumn( grids.GridColumn ): """ Column for filtering by history id. """ https://bitbucket.org/galaxy/galaxy-central/commits/516df888b97a/ Changeset: 516df888b97a User: jgoecks Date: 2013-11-14 17:00:58 Summary: Merge stable with default branch. Affected #: 1 file diff -r 7553213e0646fd4337ceacc78820990c6ce0c710 -r 516df888b97a164b7ff2d8235f5d4ea6462e185d lib/galaxy/webapps/galaxy/controllers/visualization.py --- a/lib/galaxy/webapps/galaxy/controllers/visualization.py +++ b/lib/galaxy/webapps/galaxy/controllers/visualization.py @@ -86,15 +86,19 @@ class DbKeyColumn( grids.GridColumn ): """ Column for filtering by and displaying dataset dbkey. """ def filter( self, trans, user, query, dbkey ): - """ Filter by dbkey; datasets without a dbkey are returned as well. """ - # use raw SQL b/c metadata is a BLOB + """ Filter by dbkey. """ + # Use raw SQL b/c metadata is a BLOB. dbkey_user, dbkey = decode_dbkey( dbkey ) dbkey = dbkey.replace("'", "\\'") - return query.filter( or_( \ - or_( "metadata like '%%\"dbkey\": [\"%s\"]%%'" % dbkey, "metadata like '%%\"dbkey\": \"%s\"%%'" % dbkey ), \ - or_( "metadata like '%%\"dbkey\": [\"?\"]%%'", "metadata like '%%\"dbkey\": \"?\"%%'" ) \ - ) - ) + return query.filter( or_( "metadata like '%%\"dbkey\": [\"%s\"]%%'" % dbkey, "metadata like '%%\"dbkey\": \"%s\"%%'" % dbkey ) ) + + #Use this query when datasets with matching dbkey *or* no dbkey can be added to the visualization. + #return query.filter( or_( \ + # or_( "metadata like '%%\"dbkey\": [\"%s\"]%%'" % dbkey, "metadata like '%%\"dbkey\": \"%s\"%%'" % dbkey ), \ + # or_( "metadata like '%%\"dbkey\": [\"?\"]%%'", "metadata like '%%\"dbkey\": \"?\"%%'" ) \ + # ) + # ) + class HistoryColumn( grids.GridColumn ): """ Column for filtering by history id. """ Repository URL: https://bitbucket.org/galaxy/galaxy-central/ -- This is a commit notification from bitbucket.org. You are receiving this because you have the service enabled, addressing the recipient of this email.