[galaxyproject/galaxy] fad562: Datatypes: include base classes in search by name
Branch: refs/heads/dev Home: https://github.com/galaxyproject/galaxy Commit: fad562876f886e3384fec1a9782685251d12e2c1 https://github.com/galaxyproject/galaxy/commit/fad562876f886e3384fec1a978268... Author: carlfeberhard <carlfeberhard@gmail.com> Date: 2016-10-10 (Mon, 10 Oct 2016) Changed paths: M lib/galaxy/datatypes/registry.py Log Message: ----------- Datatypes: include base classes in search by name Fixes #2982 Adds the base class 'images.Image' to the list of classes returnable by 'datatypes_registry.get_datatype_class_by_name'. Normally that method searches the registry's list of datatypes and those are instantiable classes only. The images.Image can be considered an abstract base class and you'd never create a dataset of that datatype. The method is used for getting classes for 'isinstance' tests, however, so including base classes like 'images.Image' allow testing for all its image subclasses. This change makes that possible and allows the method (and its consumers) to behave in a much more predictable and useful manner. Commit: 191bae9a2b9d06bb7d461633b0a43ce320a042c4 https://github.com/galaxyproject/galaxy/commit/191bae9a2b9d06bb7d461633b0a43... Author: John Chilton <jmchilton@gmail.com> Date: 2016-10-10 (Mon, 10 Oct 2016) Changed paths: M lib/galaxy/datatypes/registry.py Log Message: ----------- Merge pull request #3028 from carlfeberhard/fix.tiff Datatypes: include base classes in search by name Compare: https://github.com/galaxyproject/galaxy/compare/75d1f8496acc...191bae9a2b9d
participants (1)
-
GitHub