I have a work-in-progress branch and pull request here, https://github.com/peterjc/galaxy/tree/blast_datatypes https://github.com/galaxyproject/galaxy/pull/2696 The Galaxy TravisCI tests looked fine. Peter On Mon, Aug 1, 2016 at 11:18 AM, Peter Cock <p.j.a.cock@googlemail.com> wrote:
Dear all,
I ran this past the IUC first, and the only comments were positive.
Although I wasn't at GCC2017 to discuss this in person, I understand that the Galaxy Team now encourages widely used datatypes to be included in the main Galaxy repository, rather than distributed via the Tool Shed.
To that end, would a pull request returning the BLAST datatypes and associated database *.loc files be welcome?
These are currently on my GitHub repository here: https://github.com/peterjc/galaxy_blast/
And the datatypes are distributed via the Tool Shed here: http://toolshed.g2.bx.psu.edu/view/devteam/blast_datatypes
Assuming this happens, we would need to phase out the tool shed version (but it will still be needed while older Galaxy instances are still running).
Are there any pitfalls to worry about if the datatypes are already there with Galaxy and the tool shed version is installed on top? Or the tool shed version was installed but then Galaxy was updated to include the version bundled with Galaxy?
Thanks,
Peter