Yes, the code is definitely broken somewhere else, not in this function, but this fix ensures that data is at least visible. However, data is right aligned as you mentioned, which is definitely undesirable.

As for getting the script onto multiple lines, you are correct, you'd need to serve the uncompressed version. Then again, I believe you're experiencing the same issue as me, because the compressed version of data.js uses column_types as 'j' and index as 'i'.

Cheers,
Eric



Peter Cock <p.j.a.cock@googlemail.com> schrieb:
On Thu, Oct 3, 2013 at 6:34 PM, Björn Grüning
<bjoern.gruening@pharmazie.uni-freiburg.de> wrote:
Hi Sam,

any chance to commit that fix to Galaxy-stable?

Thanks!
Bjoern

The error Sam and Eric reported is different to mine, and so this
doesn't solve the display issue on my machine:

$ hg diff static/scripts/mvc/data.js
diff -r c42567f43aa7 static/scripts/mvc/data.js
--- a/static/scripts/mvc/data.js Mon Aug 19 13:19:56 2013 -0400
+++ b/static/scripts/mvc/data.js Fri Oct 04 09:44:39 2013 +0100
@@ -185,10 +185,10 @@
if (colspan !== undefined) {
return $('<td>').attr('colspan',
colspan).addClass('stringalign').text(cell_contents);
}
- else if (column_types[index] === 'str' || column_types === 'list') {
- /* Left align all str columns, right align the rest */
- return $('<td>').addClass('stringalign').text(cell_contents);
- }
+ //else if (column_types[index] === 'str' || column_types === 'list') {
+ // /* Left align all str columns, right align the rest */
+ // return $('<td>').addClass('stringalign').text(cell_contents);
+ //}
else {
return $('<td>').text(cell_contents);
}

This bit code hasn't changed on the galaxy-central, so
whatever is breaking the column_types on Eric's machine
seems to be coming from elsewhere. The workaround
looks like it would have the downside of right align string
columns, which is undesirable.

Eric, is there a simple trick to get data.js into the browser
with multiple lines? Right now Firefox tells me the 'j' error
is on line one because the entire file is one long line :(
< br />[09:47:34.057] TypeError: j is undefined @
http://xxx/galaxy/static/scripts/mvc/data.js:1

Presumably I need Galaxy to serve data.js uncompressed?

Thanks,

Peter



Please keep all replies on the list by using "reply all"
in your mail client. To manage your subscriptions to this
and other Galaxy lists, please use the interface at:
http://lists.bx.psu.edu/

To search Galaxy mailing lists use the unified search at:
http://galaxyproject.org/search/mailinglists/

--
Sent from my Android phone with K-9 Mail. Please excuse my brevity.