details: http://www.bx.psu.edu/hg/galaxy/rev/4686a93802c0 changeset: 3316:4686a93802c0 user: Greg Von Kuster <greg@bx.psu.edu> date: Tue Feb 02 16:49:00 2010 -0500 description: Fix a bug in ChcekboxField.get_html() - need to include the prefix in the hidden field so it will work inside conditionals. Fixes ticket # #257. diffstat: lib/galaxy/web/form_builder.py | 9 +++++---- 1 files changed, 5 insertions(+), 4 deletions(-) diffs (21 lines): diff -r ac6e08aed7d4 -r 4686a93802c0 lib/galaxy/web/form_builder.py --- a/lib/galaxy/web/form_builder.py Tue Feb 02 12:23:50 2010 -0500 +++ b/lib/galaxy/web/form_builder.py Tue Feb 02 16:49:00 2010 -0500 @@ -104,12 +104,13 @@ """ def __init__( self, name, checked=None ): self.name = name - self.checked = (checked == True) or (type(checked) == type('a') and (checked.lower() in ( "yes", "true", "on" ))) + self.checked = ( checked == True ) or ( type( checked ) == type( 'a' ) and ( checked.lower() in ( "yes", "true", "on" ) ) ) def get_html( self, prefix="" ): - if self.checked: checked_text = "checked" + if self.checked: + checked_text = "checked" else: checked_text = "" - return '<input type="checkbox" name="%s%s" value="true" %s><input type="hidden" name="%s" value="true">' \ - % ( prefix, self.name, checked_text, self.name ) + return '<input type="checkbox" name="%s%s" value="true" %s><input type="hidden" name="%s%s" value="true">' \ + % ( prefix, self.name, checked_text, prefix, self.name ) @staticmethod def is_checked( value ): if value == True: # wierd behaviour caused by following check for 2 valued list - wtf? ross august 22