details: http://www.bx.psu.edu/hg/galaxy/rev/49a7de2c4707 changeset: 3547:49a7de2c4707 user: jeremy goecks <jeremy.goecks@emory.edu> date: Thu Mar 18 22:41:15 2010 -0400 description: Fix tag filtering bug for published item grids. diffstat: templates/display_base.mako | 2 +- templates/grid_base.mako | 2 +- templates/history/view.mako | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diffs (36 lines): diff -r be396d94ca5a -r 49a7de2c4707 templates/display_base.mako --- a/templates/display_base.mako Thu Mar 18 16:02:09 2010 -0400 +++ b/templates/display_base.mako Thu Mar 18 22:41:15 2010 -0400 @@ -43,7 +43,7 @@ <% controller_name = get_controller_name( item ) %> var href = '${h.url_for ( controller='/' + controller_name , action='list_published')}'; href = href + "?f-tags=" + tag_name; - if (tag_value != null && tag_value != "") + if (tag_value != undefined && tag_value != "") href = href + ":" + tag_value; self.location = href; } diff -r be396d94ca5a -r 49a7de2c4707 templates/grid_base.mako --- a/templates/grid_base.mako Thu Mar 18 16:02:09 2010 -0400 +++ b/templates/grid_base.mako Thu Mar 18 22:41:15 2010 -0400 @@ -345,7 +345,7 @@ // Add tag to grid filter. function add_tag_to_grid_filter(tag_name, tag_value) { // Put tag name and value together. - var tag = tag_name + (tag_value !== null && tag_value != "" ? ":" + tag_value : ""); + var tag = tag_name + (tag_value !== undefined && tag_value != "" ? ":" + tag_value : ""); $('#more-search-options').show('fast'); add_filter_condition("tags", tag, true); } diff -r be396d94ca5a -r 49a7de2c4707 templates/history/view.mako --- a/templates/history/view.mako Thu Mar 18 16:02:09 2010 -0400 +++ b/templates/history/view.mako Thu Mar 18 22:41:15 2010 -0400 @@ -258,7 +258,7 @@ { var href = '${h.url_for( controller='/history', action='list_published')}'; href = href + "?f-tags=" + tag_name; - if (tag_value != null && tag_value != "") + if (tag_value != undefined && tag_value != "") href = href + ":" + tag_value; self.location = href; }