Upload files from filesystem paths - backwards checkboxes
Hi all, Via the Galaxy admin interface, I'm currently importing some BAM files into a library from the local file system. Since they are big, I don't want Galaxy to copy them. So I looked at the "Copy data into Galaxy?" option and made sure it wasn't ticked. Galaxy did copy the file :( I looked at the interface again, and see you have:
Copy data into Galaxy? [check box] No Normally data uploaded with this tool is copied into Galaxy's "files" directory so any later changes to the data will not affect Galaxy. However, this may not be desired (especially for large NGS datasets), so use of this option will force Galaxy to always read the data from its original path.
You've got a tick box labelled "No" so it does the opposite to the question above it. That is a HORRIBLE interface. I can't be the first person to be tricked by it, can I? I would urge you to remove the work "No" and flip the meaning (and default) to match. But that could confuse existing admin users used to clicking from previous habit. How about making it a select parameter instead, with options "Copy files (default)" and "Link to files" which is very explicit? Likewise for the "Preserve directory structure?" setting, I'd remove the "No" caption and flip the setting, or just replace the backwards tick box with a select parameter offering "Preserve directory structure" and "Place in selected folder" (or something like that). Pretty please? How about if I write and test the patch? Peter
On Mar 10, 2011, at 12:24 PM, Peter Cock wrote:
Hi all,
Via the Galaxy admin interface, I'm currently importing some BAM files into a library from the local file system. Since they are big, I don't want Galaxy to copy them.
So I looked at the "Copy data into Galaxy?" option and made sure it wasn't ticked. Galaxy did copy the file :(
I looked at the interface again, and see you have:
Copy data into Galaxy? [check box] No Normally data uploaded with this tool is copied into Galaxy's "files" directory so any later changes to the data will not affect Galaxy. However, this may not be desired (especially for large NGS datasets), so use of this option will force Galaxy to always read the data from its original path.
You've got a tick box labelled "No" so it does the opposite to the question above it. That is a HORRIBLE interface. I can't be the first person to be tricked by it, can I?
I had a co-worker mess this up too. I thought this was a poor design decision. I thought maybe yes/no radio options would work. "Copy data into galaxy? yes(*) no( )"
I would urge you to remove the work "No" and flip the meaning (and default) to match. But that could confuse existing admin users used to clicking from previous habit.
How about making it a select parameter instead, with options "Copy files (default)" and "Link to files" which is very explicit?
I think this would be better than the current "no" check box, and more explicit than my yes(*) no () radio buttons
Likewise for the "Preserve directory structure?" setting, I'd remove the "No" caption and flip the setting, or just replace the backwards tick box with a select parameter offering "Preserve directory structure" and "Place in selected folder" (or something like that).
Pretty please? How about if I write and test the patch?
Peter ___________________________________________________________ Please keep all replies on the list by using "reply all" in your mail client. To manage your subscriptions to this and other Galaxy lists, please use the interface at:
-- Glen L. Beane Senior Software Engineer The Jackson Laboratory (207) 288-6153
On Thu, Mar 10, 2011 at 5:53 PM, Glen Beane <Glen.Beane@jax.org> wrote:
On Mar 10, 2011, at 12:24 PM, Peter Cock wrote:
Hi all,
Via the Galaxy admin interface, I'm currently importing some BAM files into a library from the local file system. Since they are big, I don't want Galaxy to copy them.
So I looked at the "Copy data into Galaxy?" option and made sure it wasn't ticked. Galaxy did copy the file :(
I looked at the interface again, and see you have:
Copy data into Galaxy? [check box] No Normally data uploaded with this tool is copied into Galaxy's "files" directory so any later changes to the data will not affect Galaxy. However, this may not be desired (especially for large NGS datasets), so use of this option will force Galaxy to always read the data from its original path.
You've got a tick box labelled "No" so it does the opposite to the question above it. That is a HORRIBLE interface. I can't be the first person to be tricked by it, can I?
I had a co-worker mess this up too. I thought this was a poor design decision. I thought maybe yes/no radio options would work. "Copy data into galaxy? yes(*) no( )"
I would urge you to remove the work "No" and flip the meaning (and default) to match. But that could confuse existing admin users used to clicking from previous habit.
How about making it a select parameter instead, with options "Copy files (default)" and "Link to files" which is very explicit?
I think this would be better than the current "no" check box, and more explicit than my yes(*) no () radio buttons
You may be right, but switching from a checkbox to a select isn't as easy as it could be... at least not with my familiarity with the code base.
Likewise for the "Preserve directory structure?" setting, I'd remove the "No" caption and flip the setting, or just replace the backwards tick box with a select parameter offering "Preserve directory structure" and "Place in selected folder" (or something like that).
Pretty please? How about if I write and test the patch?
Patch for flipping the "Preserve directory structure?" setting, which I hope you can test then merge/transplant to the trunk: https://bitbucket.org/peterjc/galaxy-central/changeset/669dcc2803ba I'm still working on the "Copy data into Galaxy?" setting... Peter
Hello Peter, Thanks for the patch - I've applied a corrected version of it in change set 5215:74c4dd43485a. Let me know if you'd rather have me flip the "Copy data into Galaxy?" feature. I'd be happy to, but I don't want to reinvent the wheel if you're close. Thanks! Greg Von Kuster On Mar 11, 2011, at 7:31 AM, Peter Cock wrote:
Patch for flipping the "Preserve directory structure?" setting, which I hope you can test then merge/transplant to the trunk:
https://bitbucket.org/peterjc/galaxy-central/changeset/669dcc2803ba
I'm still working on the "Copy data into Galaxy?" setting...
Greg Von Kuster Galaxy Development Team greg@bx.psu.edu
On Fri, Mar 11, 2011 at 3:04 PM, Greg Von Kuster <greg@bx.psu.edu> wrote:
Hello Peter,
Thanks for the patch - I've applied a corrected version of it in change set 5215:74c4dd43485a. Let me know if you'd rather have me flip the "Copy data into Galaxy?" feature. I'd be happy to, but I don't want to reinvent the wheel if you're close.
Thanks!
Greg Von Kuster
Using util.string_as_bool looks good - I didn't know about that and it looks far more rhobust. Would you might doing "Copy data into Galaxy? as well? I got most of the way but got dragged off to a meeting in the middle. Thanks! Peter
Hi Peter, This has been resolved in change set 5217:70d7d0bfaad6, where I've changed the check box into a select list per your suggestion. Thanks! Greg Von Kuster On Mar 10, 2011, at 12:24 PM, Peter Cock wrote:
Hi all,
Via the Galaxy admin interface, I'm currently importing some BAM files into a library from the local file system. Since they are big, I don't want Galaxy to copy them.
So I looked at the "Copy data into Galaxy?" option and made sure it wasn't ticked. Galaxy did copy the file :(
I looked at the interface again, and see you have:
Copy data into Galaxy? [check box] No Normally data uploaded with this tool is copied into Galaxy's "files" directory so any later changes to the data will not affect Galaxy. However, this may not be desired (especially for large NGS datasets), so use of this option will force Galaxy to always read the data from its original path.
You've got a tick box labelled "No" so it does the opposite to the question above it. That is a HORRIBLE interface. I can't be the first person to be tricked by it, can I?
I would urge you to remove the work "No" and flip the meaning (and default) to match. But that could confuse existing admin users used to clicking from previous habit.
How about making it a select parameter instead, with options "Copy files (default)" and "Link to files" which is very explicit?
Likewise for the "Preserve directory structure?" setting, I'd remove the "No" caption and flip the setting, or just replace the backwards tick box with a select parameter offering "Preserve directory structure" and "Place in selected folder" (or something like that).
Pretty please? How about if I write and test the patch?
Peter ___________________________________________________________ Please keep all replies on the list by using "reply all" in your mail client. To manage your subscriptions to this and other Galaxy lists, please use the interface at:
Greg Von Kuster Galaxy Development Team greg@bx.psu.edu
participants (3)
-
Glen Beane -
Greg Von Kuster -
Peter Cock