details: http://www.bx.psu.edu/hg/galaxy/rev/8e3d63d7cd8a changeset: 1661:8e3d63d7cd8a user: Greg Von Kuster greg@bx.psu.edu date: Fri Dec 12 11:53:06 2008 -0500 description: Bug fix for users report controller, some users may not yet have logged in.

1 file(s) affected in this change:

lib/galaxy/webapps/reports/controllers/users.py

diffs (20 lines):

diff -r 254c86053312 -r 8e3d63d7cd8a lib/galaxy/webapps/reports/controllers/users.py --- a/lib/galaxy/webapps/reports/controllers/users.py Fri Dec 12 10:15:37 2008 -0500 +++ b/lib/galaxy/webapps/reports/controllers/users.py Fri Dec 12 11:53:06 2008 -0500 @@ -105,9 +105,13 @@ now = strftime( "%Y-%m-%d %H:%M:%S" ) users = [] for user in galaxy.model.User.query().order_by( galaxy.model.User.table.c.email ).all(): - last_galaxy_session = user.galaxy_sessions[ 0 ] - if last_galaxy_session.update_time < cutoff_time: - users.append( ( user.email, last_galaxy_session.update_time.strftime( "%Y-%m-%d" ) ) ) + if user.galaxy_sessions: + last_galaxy_session = user.galaxy_sessions[ 0 ] + if last_galaxy_session.update_time < cutoff_time: + users.append( ( user.email, last_galaxy_session.update_time.strftime( "%Y-%m-%d" ) ) ) + else: + # The user has never logged in + users.append( ( user.email, "never logged in" ) ) return trans.fill_template( 'users_last_access_date.mako', users=users, not_logged_in_for_days=not_logged_in_for_days,