keep job output and scripts on failed tests
I'd like to recommend a change. If jobs fail to run during functional tests, I'd like to keep the failed job files around to be examined. I added the following to do so: +++ scripts/functional_tests.py @@ -372,6 +372,7 @@ def main(): user_library_import_dir=user_library_import_dir, master_api_key=master_api_key, use_tasked_jobs=True, + cleanup_job='onsuccess' ) if install_database_connection is not None: kwargs[ 'install_database_connection' ] = install_database_connection
Hi Ryan, Something very handy for tool developers running functional tests is if the environment variable GALAXY_TEST_NO_CLEANUP is set, run_tests.sh shouldn't remove the test output. This is great when debugging why a test is failing. Peter On Fri, Jun 12, 2015 at 4:29 PM, Ryan G <ngsbioinformatics@gmail.com> wrote:
I'd like to recommend a change. If jobs fail to run during functional tests, I'd like to keep the failed job files around to be examined. I added the following to do so:
+++ scripts/functional_tests.py @@ -372,6 +372,7 @@ def main(): user_library_import_dir=user_library_import_dir, master_api_key=master_api_key, use_tasked_jobs=True, + cleanup_job='onsuccess' ) if install_database_connection is not None: kwargs[ 'install_database_connection' ] = install_database_connection
___________________________________________________________ Please keep all replies on the list by using "reply all" in your mail client. To manage your subscriptions to this and other Galaxy lists, please use the interface at: https://lists.galaxyproject.org/
To search Galaxy mailing lists use the unified search at: http://galaxyproject.org/search/mailinglists/
I tried that and the directories don't get removed however the job files still get deleted. On Fri, Jun 12, 2015 at 12:03 PM, Peter Cock <p.j.a.cock@googlemail.com> wrote:
Hi Ryan,
Something very handy for tool developers running functional tests is if the environment variable GALAXY_TEST_NO_CLEANUP is set, run_tests.sh shouldn't remove the test output.
This is great when debugging why a test is failing.
Peter
On Fri, Jun 12, 2015 at 4:29 PM, Ryan G <ngsbioinformatics@gmail.com> wrote:
I'd like to recommend a change. If jobs fail to run during functional tests, I'd like to keep the failed job files around to be examined. I added the following to do so:
+++ scripts/functional_tests.py @@ -372,6 +372,7 @@ def main(): user_library_import_dir=user_library_import_dir, master_api_key=master_api_key, use_tasked_jobs=True, + cleanup_job='onsuccess' ) if install_database_connection is not None: kwargs[ 'install_database_connection' ] = install_database_connection
___________________________________________________________ Please keep all replies on the list by using "reply all" in your mail client. To manage your subscriptions to this and other Galaxy lists, please use the interface at: https://lists.galaxyproject.org/
To search Galaxy mailing lists use the unified search at: http://galaxyproject.org/search/mailinglists/
Hmm. That may need a tweak - using GALAXY_TEST_NO_CLEANUP is not the default, so this could easily be a regression. Peter On Fri, Jun 12, 2015 at 6:09 PM, Ryan G <ngsbioinformatics@gmail.com> wrote:
I tried that and the directories don't get removed however the job files still get deleted.
On Fri, Jun 12, 2015 at 12:03 PM, Peter Cock <p.j.a.cock@googlemail.com> wrote:
Hi Ryan,
Something very handy for tool developers running functional tests is if the environment variable GALAXY_TEST_NO_CLEANUP is set, run_tests.sh shouldn't remove the test output.
This is great when debugging why a test is failing.
Peter
On Fri, Jun 12, 2015 at 4:29 PM, Ryan G <ngsbioinformatics@gmail.com> wrote:
I'd like to recommend a change. If jobs fail to run during functional tests, I'd like to keep the failed job files around to be examined. I added the following to do so:
+++ scripts/functional_tests.py @@ -372,6 +372,7 @@ def main(): user_library_import_dir=user_library_import_dir, master_api_key=master_api_key, use_tasked_jobs=True, + cleanup_job='onsuccess' ) if install_database_connection is not None: kwargs[ 'install_database_connection' ] = install_database_connection
___________________________________________________________ Please keep all replies on the list by using "reply all" in your mail client. To manage your subscriptions to this and other Galaxy lists, please use the interface at: https://lists.galaxyproject.org/
To search Galaxy mailing lists use the unified search at: http://galaxyproject.org/search/mailinglists/
Hey Ryan, Thanks - this seems like a solid enhancement - I have opened a pull request for it here https://github.com/galaxyproject/galaxy/pull/341. -John On Fri, Jun 12, 2015 at 2:19 PM, Peter Cock <p.j.a.cock@googlemail.com> wrote:
Hmm.
That may need a tweak - using GALAXY_TEST_NO_CLEANUP is not the default, so this could easily be a regression.
Peter
On Fri, Jun 12, 2015 at 6:09 PM, Ryan G <ngsbioinformatics@gmail.com> wrote:
I tried that and the directories don't get removed however the job files still get deleted.
On Fri, Jun 12, 2015 at 12:03 PM, Peter Cock <p.j.a.cock@googlemail.com> wrote:
Hi Ryan,
Something very handy for tool developers running functional tests is if the environment variable GALAXY_TEST_NO_CLEANUP is set, run_tests.sh shouldn't remove the test output.
This is great when debugging why a test is failing.
Peter
On Fri, Jun 12, 2015 at 4:29 PM, Ryan G <ngsbioinformatics@gmail.com> wrote:
I'd like to recommend a change. If jobs fail to run during functional tests, I'd like to keep the failed job files around to be examined. I added the following to do so:
+++ scripts/functional_tests.py @@ -372,6 +372,7 @@ def main(): user_library_import_dir=user_library_import_dir, master_api_key=master_api_key, use_tasked_jobs=True, + cleanup_job='onsuccess' ) if install_database_connection is not None: kwargs[ 'install_database_connection' ] = install_database_connection
___________________________________________________________ Please keep all replies on the list by using "reply all" in your mail client. To manage your subscriptions to this and other Galaxy lists, please use the interface at: https://lists.galaxyproject.org/
To search Galaxy mailing lists use the unified search at: http://galaxyproject.org/search/mailinglists/
___________________________________________________________ Please keep all replies on the list by using "reply all" in your mail client. To manage your subscriptions to this and other Galaxy lists, please use the interface at: https://lists.galaxyproject.org/
To search Galaxy mailing lists use the unified search at: http://galaxyproject.org/search/mailinglists/
participants (3)
-
John Chilton -
Peter Cock -
Ryan G