Darnit, I should have tried downloading again before sending the email - that solved the issue.

Newest version of upload.py doesn't make use of from_json_string

Cheers,

Rob

________________________________ From: Robert Davidson bobbledavidson@yahoo.co.uk To: "galaxy-dev@lists.bx.psu.edu" galaxy-dev@lists.bx.psu.edu Sent: Monday, 3 November 2014, 15:33 Subject: Problems with upload.py and changes to json.py

Dear Galaxy-Dev,

Last week I downloaded a fresh version of Galaxy with all stable updates. I've just come across a NameError in the upload.py tool.

---- Traceback (most recent call last): File "/home/rob/galaxy-dist/tools/data_source/upload.py", line 390, in <module> __main__() File "/home/rob/galaxy-dist/tools/data_source/upload.py", line 368, in __main__ dataset = from_json_string( line ) NameError: global name 'from_json_string' is not defined ----

A quick investigation led me to: from galaxy.util.json import *

and from there to json.py. I compared this file with my previous version and note that there are quite a few changes.

The problem seems to be that from_json_string() is not included in the __all__ list of public functions... can someone tell me if this is a bug/oversight or if I'm missing something?

Cheers,

Rob