Deleting history entries not working, javascript void link?
Hi all, I've just updated our main Galaxy to release_2013.11.04 but also see the following problem on galaxy-central, and on https://usegalaxy.org/ as well. (1) Go to any history with deleted files (2) Cog icon, tick "Include Deleted datasets" (3) Look at a deleted dataset in your history column, note the yellow "Warning" box with text: This dataset has been deleted. Click *here* to undelete it or *here* to immediately remove it from disk (4) Notice the first *here* link (undelete) has a sensible URL, e.g. as shown via your browser's status bar or right click to copy the URL. (5) Notice the second *here* (remove) has this as the URL: javascript:void(0) Unsurprisingly, the remove link has no effect as it is a JavaScript command to do nothing, and the user cannot therefore purge the file from their history. I've confirmed this on multiple browsers on multiple machines. Regards, Peter
Hello, Peter. Thanks for the report. There was an error in the javascript error handling of purge_async which is now fixed in stable:11227:151b7d3b2f1b. In the instances you mention, you should now see an error message in the history 'Unable to purge this dataset': This is because of two possible reasons: - the setting 'allow_user_dataset_purge' in universe_wsgi.ini is 'False' (or commented out) - there was an error in the call to purge_async on the server The 'href="javascript:void(0);"' is a common idiom for creating links/anchors where the logic is handled on the client side. It tells the browser that, although the element has all the other properties of a link, it should not load it like another page and the click event will be handled by javascript on the current page. In the default branch, the error reporting has been (hopefully) improved to display appropriate messages for failed purging as well as better reporting overall. Sorry for the inconvenience. On Tue, Nov 5, 2013 at 7:02 AM, Peter Cock <p.j.a.cock@googlemail.com>wrote:
Hi all,
I've just updated our main Galaxy to release_2013.11.04 but also see the following problem on galaxy-central, and on https://usegalaxy.org/ as well.
(1) Go to any history with deleted files (2) Cog icon, tick "Include Deleted datasets" (3) Look at a deleted dataset in your history column, note the yellow "Warning" box with text:
This dataset has been deleted. Click *here* to undelete it or *here* to immediately remove it from disk
(4) Notice the first *here* link (undelete) has a sensible URL, e.g. as shown via your browser's status bar or right click to copy the URL. (5) Notice the second *here* (remove) has this as the URL: javascript:void(0)
Unsurprisingly, the remove link has no effect as it is a JavaScript command to do nothing, and the user cannot therefore purge the file from their history.
I've confirmed this on multiple browsers on multiple machines.
Regards,
Peter ___________________________________________________________ Please keep all replies on the list by using "reply all" in your mail client. To manage your subscriptions to this and other Galaxy lists, please use the interface at: http://lists.bx.psu.edu/
To search Galaxy mailing lists use the unified search at: http://galaxyproject.org/search/mailinglists/
participants (2)
-
Carl Eberhard -
Peter Cock