Branch: refs/heads/dev Home: https://github.com/galaxyproject/galaxy Commit: 5dfb743ae160f873db670bff26d3ba19d85d4ce9 https://github.com/galaxyproject/galaxy/commit/5dfb743ae160f873db670bff26d3b... Author: Nicola Soranzo nicola.soranzo@earlham.ac.uk Date: 2018-10-24 (Wed, 24 Oct 2018)
Changed paths: M lib/galaxy/tools/parameters/dynamic_options.py
Log Message: ----------- Allow ``remove_value`` filter on data tables
The `RemoveValueFilter.filter_options()` method was expecting `options` to be a list of lists, where each inner list contains exactly 3-elements (name, value, selected), which is the format returned by the `data_meta` filter. In fact, the only known use of the `remove_falue` filter is in the tool `tools/maf/maf_to_interval.xml`, to filter dataset metadata.
This commit generalises the filter to look for a column of the dynamic options named `value`, and use it during the filtering.
Fix https://github.com/galaxyproject/tools-iuc/issues/2151
Commit: 26680e0ca1ace0ad8c857ab712f60d2fc4bf8c1b https://github.com/galaxyproject/galaxy/commit/26680e0ca1ace0ad8c857ab712f60... Author: mvdbeek m.vandenbeek@gmail.com Date: 2018-10-24 (Wed, 24 Oct 2018)
Changed paths: A test/functional/tools/remove_value.xml M test/functional/tools/samples_tool_conf.xml
Log Message: ----------- Add test for remove_value form dynamic options
Unfortunately you can select an invalid value (in the API, not the UI) and Galaxy will replace the invalid value with the first valid value.
Commit: 7c81daa073dea39785144b9228b53b2cd9f6fdbe https://github.com/galaxyproject/galaxy/commit/7c81daa073dea39785144b9228b53... Author: Nicola Soranzo nicola.soranzo@gmail.com Date: 2018-10-24 (Wed, 24 Oct 2018)
Changed paths: M lib/galaxy/tools/parameters/dynamic_options.py
Log Message: ----------- Fix assertion in ``RemoveValueFilter``
Commit: 19c98b27455862e7f50570bbc147a28667182e31 https://github.com/galaxyproject/galaxy/commit/19c98b27455862e7f50570bbc147a... Author: mvdbeek m.vandenbeek@gmail.com Date: 2018-10-24 (Wed, 24 Oct 2018)
Changed paths: M test/functional/tools/remove_value.xml
Log Message: ----------- Fix tests and name tool more appropriately
Commit: 014b9d76f76c2eb959266bc271ad0539a1ab0f6d https://github.com/galaxyproject/galaxy/commit/014b9d76f76c2eb959266bc271ad0... Author: Marius van den Beek m.vandenbeek@gmail.com Date: 2018-10-24 (Wed, 24 Oct 2018)
Changed paths: M lib/galaxy/tools/parameters/dynamic_options.py A test/functional/tools/remove_value.xml M test/functional/tools/samples_tool_conf.xml
Log Message: ----------- Merge pull request #6914 from nsoranzo/remove_value
Allow ``remove_value`` filter on data tables
Compare: https://github.com/galaxyproject/galaxy/compare/51ca8dc0f5d4...014b9d76f76c **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/
Functionality will be removed from GitHub.com on January 31st, 2019.