1 new commit in galaxy-central:
https://bitbucket.org/galaxy/galaxy-central/commits/68a8b0397947/ Changeset: 68a8b0397947 Branch: stable User: nsoranzo Date: 2014-05-19 18:03:21 Summary: Fix for "'HistoryTagsController' object has no attribute 'security_check'".
Trying to access /api/histories/$history_id/tags gives this error:
Execption in get_object check for History 1723db999e478a37: 'HistoryTagsController' object has no attribute 'security_check' Traceback (most recent call last): File "/opt/galaxy/lib/galaxy/web/base/controller.py", line 233, in get_object check_ownership=check_ownership, check_accessible=check_accessible, deleted=deleted ) File "/opt/galaxy/lib/galaxy/web/base/controller.py", line 131, in get_object self.security_check( trans, item, check_ownership, check_accessible ) AttributeError: 'HistoryTagsController' object has no attribute 'security_check'
The same happens for workflow tags. Affected #: 2 files
diff -r cc0fe62e54dc59607c26cd9152ef1ea7c85af625 -r 68a8b0397947c732b28207d465d3f3c4e2a7a8a0 lib/galaxy/web/base/controller.py --- a/lib/galaxy/web/base/controller.py +++ b/lib/galaxy/web/base/controller.py @@ -221,7 +221,7 @@ except MessageException: raise # handled in the caller except: - log.exception( "Execption in get_object check for %s %s:" % ( class_name, str( id ) ) ) + log.exception( "Exception in get_object check for %s %s:" % ( class_name, str( id ) ) ) raise Exception( 'Server error retrieving %s id ( %s ).' % ( class_name, str( id ) ) )
@@ -237,7 +237,7 @@ except MessageException, e: raise HTTPBadRequest( detail=e.err_msg ) except Exception, e: - log.exception( "Execption in get_object check for %s %s: %s" % ( class_name, str( id ), str( e ) ) ) + log.exception( "Exception in get_object check for %s %s: %s" % ( class_name, str( id ), str( e ) ) ) raise HTTPInternalServerError( comment=str( e ) )
def validate_in_users_and_groups( self, trans, payload ): @@ -2779,7 +2779,7 @@ return self.get_object( trans, id, 'Quota', check_ownership=False, check_accessible=False, deleted=deleted )
-class UsesTagsMixin( object ): +class UsesTagsMixin( SharableItemSecurityMixin ):
def get_tag_handler( self, trans ): return trans.app.tag_handler
diff -r cc0fe62e54dc59607c26cd9152ef1ea7c85af625 -r 68a8b0397947c732b28207d465d3f3c4e2a7a8a0 lib/galaxy/webapps/galaxy/api/item_tags.py --- a/lib/galaxy/webapps/galaxy/api/item_tags.py +++ b/lib/galaxy/webapps/galaxy/api/item_tags.py @@ -4,7 +4,7 @@ import logging from galaxy import web from galaxy.web.base.controller import BaseAPIController, UsesTagsMixin -from paste.httpexceptions import HTTPNotImplemented, HTTPBadRequest +from paste.httpexceptions import HTTPBadRequest
log = logging.getLogger( __name__ )
Repository URL: https://bitbucket.org/galaxy/galaxy-central/
--
This is a commit notification from bitbucket.org. You are receiving this because you have the service enabled, addressing the recipient of this email.